-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix theme for new scoping in VSCode 1.9 #35
Comments
I'll be working on this ASAP. Hold tight everyone and sorry for the inconvenience :( |
I just released a version 1.0.0, it brings minimal support for version 1.9. Some languages simply don't have good support in VS Code and won't allow for good coloring (e.g. Java). I still have a lot of work in front of me. I believe I can achieve the same support I had before 1.9, some languages (e.g. Python) are still really bad at the moment compared to the last version. I'm sorry about that, I'm working on it. I'll update this issue as I make progress. |
To anyone waiting, I believe version 1.1.0 now has the same coloring it had before version 1.9. You can just update on VSCode Marketplace. Some languages got improved with the new scopes, like Ruby and JS/TS but if you find any inconsistency, specially one that did not exist prior to 1.9, please report. I believe the only languages missing now are the ones that depend on plugins on VSCode that I supported before 1.9, like Rust. I'll work on them over the week and close this issue when they are released. Thanks for the patience :) |
I found the following inconsistency. Language: JavaScript The problem seems to be with brackets and code inside them. The sample code is export default class Definition {
constructor(def) {
if (invalidParams(def)) {
throw new Error('Invalid arguments provided to Lang constructor');
}
this.__def = def instanceof Map ? def : new Map(def);
}
clone = () => new Definition(new Map(this.__def));
extend = (def) => {
if (invalidParams(def)) {
throw new Error(`extend requires Map`);
}
const extendedLang = new Map(this.__def);
for (const [key, value] of def) {
extendedLang.set(key, value);
}
return new Definition(extendedLang);
}
} |
Thanks for reporting! I'll take a look at this tonight and get back to you. |
Fixed. I'll hold until I have the remaining work done so I don't flood users with a new version everyday (received a few complainings about that in the past). This will be released in version 1.2.0. For comparison, The Thanks again for contributing :) |
Thanks for the quick turnaround! One question though: The const declarations worked correctly before 1.9 and also if you look, the const declaration in |
Thanks for detailed explanation! |
Can you make an option for coloring all variables types consistently? (in red I guess) |
import * as styles from './mission.scss';
export default function MissionIcon({ key, title }) {
return <i class={classnames(
styles['mission__icon'],
{
[styles['mission__icon-letter']]: title.match(A_HEBREW_LETTER),
[styles['mission__icon-first']]: !key,
}
)}>{title}</i>;
} Thank you! |
Can you provide a little more information? Is this a JS or TS file? Is this React? |
|
@akamud It's JS React |
I'll create a new issue to track this JS React issues. Please use #36 to follow this discussion. |
Version 1.2.0 now has the same support for plugins as before. If you find any other inconsistency, please create a new issue. |
VSCode 1.9 completely changed the way it handles tmTheme scopes for coloring.
The whole theme is broken at the moment and needs to be pretty much re-done from zero.
More information: microsoft/vscode#18357
The text was updated successfully, but these errors were encountered: