Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update due to the new semantic highlighting setting #119

Closed
MoKhajavi75 opened this issue Mar 11, 2020 · 6 comments
Closed

Update due to the new semantic highlighting setting #119

MoKhajavi75 opened this issue Mar 11, 2020 · 6 comments
Labels
new-version-broken vscode-issue Means that VSCode broke the theme support and you should update it.

Comments

@MoKhajavi75
Copy link

Hey

As you can see in this issue, there is a new semanticHighlighting which breaks the theme and they asked theme maintainers to update the theme.

changelog

@MoKhajavi75 MoKhajavi75 changed the title Update due to the new Update due to the new semantic highlighting setting Mar 11, 2020
@akamud
Copy link
Owner

akamud commented Mar 11, 2020

Thank you for bringing this to my attention. I'll release a new version fixing this issue.

@MoKhajavi75
Copy link
Author

MoKhajavi75 commented Mar 11, 2020

Thanks!
It would be great if we can have #95 in new release too 😁

@akamud
Copy link
Owner

akamud commented Mar 15, 2020

Ok, it looks like this was not intended to be the default, so the next update (probably a 1.43.1) will disable this behavior and give us enough time to update our themes when we feel we are ready for the new tokenizations.

I see the code is in place already to disable this behavior as default, so we should just wait for an update and everything should come back to normal until I have the time to update with the enhancements. I can confirm this is the behavior in the insiders already.

In the meantime, as people already said, you should set this in your settings:

"editor.semanticHighlighting.enabled": false

I'm following the other issues not related to this.

@akamud akamud closed this as completed Mar 15, 2020
@akamud akamud added new-version-broken vscode-issue Means that VSCode broke the theme support and you should update it. labels Mar 15, 2020
@akamud
Copy link
Owner

akamud commented Mar 15, 2020

#95 is released in 2.2.0.

@AbdelrahmanHafez
Copy link

Is this fixed?

using Atom One Dark v2.2.0, VSCode v1.43.1, with

"editor.semanticHighlighting.enabled": false

Current colors:
Screenshot_323

As far as I can remember, object properties in JS had the same colors as the variable a in this example.

Am I missing something?

@akamud
Copy link
Owner

akamud commented Mar 24, 2020

As I commented on #123, this is the new behavior in Atom as well. I give more details on how to bring back the old behavior and the reason behind this in the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-version-broken vscode-issue Means that VSCode broke the theme support and you should update it.
Projects
None yet
Development

No branches or pull requests

3 participants