Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS version never changes #742

Open
vitorgalvao opened this issue Oct 9, 2021 · 0 comments
Open

macOS version never changes #742

vitorgalvao opened this issue Oct 9, 2021 · 0 comments
Labels

Comments

@vitorgalvao
Copy link

Describe the bug
The macOS app has static version information (seemingly) because Info.plist is never updated. Versions are always at 1.0.0 (CFBundleShortVersionString) and 1 (CFBundleVersion). Version should be updated with releases.

To Reproduce
Verify Info.plist has fixed CFBundleShortVersionString and CFBundleVersion which are not updated during the build process.

Expected behavior
Version should be updated with releases.

Screenshots
N/A

Software involved
Please complete the following information:

  • OS: macOS (any version)
  • Ajour version: all of them

Additional context
If versions are not set during the build process, they can be added after it’s done by directly editing the Info.plist:

# Change these values
app_path='/PATH/TO/APP/HERE'
app_version='VERSION NUMBER HERE'

# Keep these as they are
/usr/libexec/PlistBuddy -c "Set :CFBundleVersion string ${app_version}" "${app_path}/Contents/Info.plist"
/usr/libexec/PlistBuddy -c "Set :CFBundleShortVersionString string ${app_version}" "${app_path}/Contents/Info.plist"

That would use the same version number for both fields. Technically they should be different (CFBundleVersion a machine readable string like 48657763 and CFBundleShortVersionString a human-centric value like 4.8.2), but even having the same version in both fields (or even one of them) would be a major improvement.

Log Output
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant