Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use UTC time #18

Open
ryandawsonuk opened this issue Jul 9, 2019 · 1 comment
Open

use UTC time #18

ryandawsonuk opened this issue Jul 9, 2019 · 1 comment

Comments

@ryandawsonuk
Copy link

I think it would be best-practice to use UTC time explicitly as the dex codebase does:

https://github.com/dexidp/dex/search?q=UTC&unscoped_q=UTC

Otherwise the code will just use whatever timezone the server is using.

I hit this when using a dex setup with a local client and this auth service running in the server. The server was on UTC and my local wasn't. So tokens generated on my local were rejected by the server, which was doing a check on when it was issued and thinking it was being used before it was even issued. It is a fringe use-case and we were able to address it by changing the local to use UTC. But it highlights why making UTC explicit might be a better practice.

@ajmyyra
Copy link
Owner

ajmyyra commented Jul 27, 2019

Indeed! I've never run into this since I'm usually always on UTC in all my machines, but definitely a good thing to have as default. Will look into it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants