Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Source" cases to "Dialogflow" connector #3953

Open
M-Shorouk opened this issue Nov 17, 2022 · 3 comments
Open

Add "Source" cases to "Dialogflow" connector #3953

M-Shorouk opened this issue Nov 17, 2022 · 3 comments
Assignees
Labels

Comments

@M-Shorouk
Copy link

M-Shorouk commented Nov 17, 2022

Is your feature request related to a problem? Please describe.

Currently, Dialogflow as a connector is only reading from "Airy Chat Plugin". As an Airy user, i need to enable Dialogflow when installed on all my "Active" connected sources connected to Airy.

Describe the solution you'd like

  1. Add the following case switch to read different sources Metadata ondialogflow-connector:

if (text != "") {
final ObjectNode node = getNode();
switch (source) {
case "google": {
final ObjectNode representative = getNode();
representative.put("representativeType", "BOT");
node.set("representative", representative);
node.put("text", text);
return mapper.writeValueAsString(node);
}
case "viber": {
node.put("text", text);
node.put("type", "text");
return mapper.writeValueAsString(node);
}
case "chatplugin":
case "instagram":
case "facebook": {
node.put("text", text);
return mapper.writeValueAsString(node);
}
case "twilio.sms":
case "twilio.whatsapp": {
node.put("Body", text);
return mapper.writeValueAsString(node);
}
case "whatsapp": {
node.put("Body", text);
return mapper.writeValueAsString(node);
}
default: {
return null;
}
}
}


## Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

## Additional context

Add any other context or screenshots about the feature request here.
@AudreyKj AudreyKj self-assigned this Nov 17, 2022
@M-Shorouk
Copy link
Author

M-Shorouk commented Dec 12, 2022

@AitorAlgorta can we do this one? I think @AudreyKj created the library for these sources where i assume is easy to add to the connector?

Also this is the DOCS update ticket

@AudreyKj
Copy link
Contributor

@M-Shorouk @AitorAlgorta The library for the sources has been merged, and it's not a lot of work to add this lib to the Dialogflow connector. However, it testing Dialogflow + all the sources would take a lot of time. So not sure we will have time to do this ticket before the release next week.

@M-Shorouk
Copy link
Author

@AudreyKj i think we were done with the source library.. can we quickly do this ticket before the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants