You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sinnwise opened this issue
Apr 30, 2024
· 2 comments
· Fixed by #1413
Labels
AioKafkaIssues related to `faststream.kafka` moduleConfluentIssues related to `faststream.confluent` moduleKafkaIssues related to Kafka functionality (confluent and aiokafka both)
Currently the Kafka Test Publisher / Subscriber combo returns early upon hitting a subscriber / topic combination.
If an application has two subscribers, across two consumer-groups listening on a single topic, FastStream does not respect that both subscribers should receive a message each from the topic. In testing only the first-matched topic would run.
forhandlerinself.broker._subscribers.values(): # pragma: no branch
iftopicinhandler.topics:
returnawaitcall_handler(
handler=handler,
message=[incoming]
ifisinstance(handler, AsyncAPIBatchSubscriber)
elseincoming,
rpc=rpc,
rpc_timeout=rpc_timeout,
Removing the return and letting each Subscriber handle the alert seems to get me closer to working behaviour (essentially we will have to create a list of subscribers attached to consumer groups and run handle on the first one in each consumer group – not sure how filters should come into play here).
Will work on a PR soon ☺️
The text was updated successfully, but these errors were encountered:
Thank you for the Issue and for the PR as well! I'll take a look close soon, sorry for waiting
Lancetnik
added
Confluent
Issues related to `faststream.confluent` module
AioKafka
Issues related to `faststream.kafka` module
Kafka
Issues related to Kafka functionality (confluent and aiokafka both)
labels
May 16, 2024
…ren't being respected (#1413)
* Commit for #1413
* Fixed bug in returned value
* Fixed bug in returned value
* Merged in from Main
* Merged in from Main
* Refectored Code slightly
* linting
* linting + formatting
* tests: remove useless markers
* Added batch tests for group_id overlap versions of subscribers
* Added batch tests for group_id overlap versions of subscribers
---------
Co-authored-by: Nikita Pastukhov <diementros@yandex.ru>
AioKafkaIssues related to `faststream.kafka` moduleConfluentIssues related to `faststream.confluent` moduleKafkaIssues related to Kafka functionality (confluent and aiokafka both)
Currently the Kafka Test Publisher / Subscriber combo returns early upon hitting a subscriber / topic combination.
If an application has two subscribers, across two
consumer-group
s listening on a single topic, FastStream does not respect that both subscribers should receive a message each from the topic. In testing only the first-matched topic would run.faststream/faststream/kafka/testing.py
Lines 94 to 102 in ed270ad
Removing the
return
and letting each Subscriber handle the alert seems to get me closer to working behaviour (essentially we will have to create a list of subscribers attached to consumer groups and runhandle
on the first one in each consumer group – not sure how filters should come into play here).Will work on a PR soon☺️
The text was updated successfully, but these errors were encountered: