Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: update permissions in gh actions #1146

Open
davorrunje opened this issue Jan 16, 2024 · 0 comments
Open

Feature: update permissions in gh actions #1146

davorrunje opened this issue Jan 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@davorrunje
Copy link
Collaborator

To suggest an idea or inquire about a new Message Broker supporting feature or any other enhancement, please follow this template:

Is your feature request related to a problem? Please describe.
Provide a clear and concise description of the problem you've encountered. For example: "I'm always frustrated when..."

Github organization is going to update the default permission defined by the permissions block in all workflows by end of January. If this block is not specified, I believe some of our workflows will fail because they require write access (e.g., release).

So, we will need to add a permission block to all workflows. Basically the Github Docs seems to indicate that we should probably be very conservative about permissions. One way to know which permission is required is to set permission to empty and see what breaks, and only add relevant permission.

name: "My workflow"

on: [ push ]

permissions: {}

jobs:
  ...

Describe the solution you'd like
Clearly and concisely describe the desired outcome or solution.

Feature code example
To help others understand the proposed feature, illustrate it with a FastStream code example:

from faststream import FastStream
...

Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've thought about.

Additional context
Include any other relevant context or screenshots related to the feature request.

@davorrunje davorrunje added the enhancement New feature or request label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant