Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: update zod results in an unexpected behaviour #320

Closed
1 of 4 tasks
maorun opened this issue Sep 1, 2023 · 3 comments
Closed
1 of 4 tasks

[Bug]: update zod results in an unexpected behaviour #320

maorun opened this issue Sep 1, 2023 · 3 comments
Labels
bug Something isn't working upstream issue

Comments

@maorun
Copy link
Contributor

maorun commented Sep 1, 2023

Which packages are impacted?

  • remix-validated-form
  • @remix-validated-form/with-zod
  • @remix-validated-form/with-yup
  • zod-form-data

What version of these packages are you using?

  • remix-validated-form : latest

Please provide a link to a minimal reproduction of the issue.

https://github.com/maorun/remix-validated-form

Steps to Reproduce the Bug or Issue

  1. git clone https://github.com/maorun/remix-validated-form
  2. run npm run vitest (looking normal)
  3. run yarn up zod
  4. run npm run vitest (missing second error)

Expected behavior

As a user, I expected the update of zod has no changed in the error messages, but the last error is missed.

Screenshots or Videos

No response

Platform

  • OS: macOS 13.4.1

Additional context

z.array(
        z.number().positive(),
).parse(['asdf',  -232])

gives an correct error

@maorun maorun added the bug Something isn't working label Sep 1, 2023
@maorun maorun changed the title [Bug]: [Bug]: update zod results in an unexpected behaviour Sep 1, 2023
@airjp73
Copy link
Owner

airjp73 commented Sep 22, 2023

Looks like this might be an upstream issue in zod: colinhacks/zod#2677

@maorun
Copy link
Contributor Author

maorun commented Sep 22, 2023

yeah that could be.
colinhacks/zod#2719 should be fix that

@maorun
Copy link
Contributor Author

maorun commented Apr 29, 2024

seems to be fixed with colinhacks/zod#2912 and #330

@maorun maorun closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream issue
Projects
None yet
Development

No branches or pull requests

2 participants