Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When a fetcher is supplied via the ValidatedForm, the non-js path stops working #273

Open
2 of 4 tasks
meza opened this issue Apr 9, 2023 · 0 comments
Open
2 of 4 tasks
Labels
bug Something isn't working

Comments

@meza
Copy link

meza commented Apr 9, 2023

Which packages are impacted?

  • remix-validated-form
  • @remix-validated-form/with-zod
  • @remix-validated-form/with-yup
  • zod-form-data

What version of these packages are you using?

  • "remix-validated-form": "4.6.11",
  • "zod": "3.21.4"
  • "@remix-validated-form/with-zod": "2.0.5",

Please provide a link to a minimal reproduction of the issue.

https://codesandbox.io/s/epic-saha-u99g03?file=/app/routes/index.tsx

Steps to Reproduce the Bug or Issue

  1. Keep Javascript on
  2. leave the input field empty
  3. submit the form
  4. see the validation work
  5. Turn JS off
  6. leave the input field empty
  7. see the validation NOT work
  8. remove the fetcher from the ValidatedForm props
  9. submit an empty field
  10. the validation works

Expected behavior

I'd expect the validation to work with a custom fetcher

Screenshots or Videos

No response

Platform

Tried on win 11, latest firefox and chrome

Additional context

No response

@meza meza added the bug Something isn't working label Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant