Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airbyte Provider does not detect updates when adding new streams to connections #67

Open
sousaherbert opened this issue Dec 6, 2023 · 1 comment

Comments

@sousaherbert
Copy link

sousaherbert commented Dec 6, 2023

Hi!

I have the following implementation in terraform and already deployed into Airbyte:

resource "airbyte_connection" "hubspot_s3_landing_zone" {
  source_id      = var.hubspot_source_id
  destination_id = var.hubspot_destination_id

  data_residency                       = "auto"
  namespace_format                     = "$${SOURCE_NAMESPACE}"
  namespace_definition                 = "custom_format"
  non_breaking_schema_updates_behavior = "ignore"
  status                               = "active"

  configurations = {
    stream = [
      {
        name         = "contacts"
        sync_mode    = "incremental_append"
        cursor_field = ["updatedAt"]
        primary_key  = [["id"]]
      }
    ]
  }

  schedule = {
    schedule_type = "manual"
  }
}

Today when I tried to add new streams as in the code below, the terraform plan did not detected the addition of new streams.

resource "airbyte_connection" "hubspot_s3_landing_zone" {
  source_id      = var.hubspot_source_id
  destination_id = var.hubspot_destination_id

  data_residency                       = "auto"
  namespace_format                     = "$${SOURCE_NAMESPACE}"
  namespace_definition                 = "custom_format"
  non_breaking_schema_updates_behavior = "ignore"
  status                               = "active"

  configurations = {
    stream = [
      {
        name         = "contacts"
        sync_mode    = "incremental_append"
        cursor_field = ["updatedAt"]
        primary_key  = [["id"]]
      },
      {
        name         = "deals"
        sync_mode    = "incremental_append"
        cursor_field = ["updatedAt"]
        primary_key  = [["id"]]
      },
      {
        name         = "owners"
        sync_mode    = "incremental_append"
        cursor_field = ["updatedAt"]
        primary_key  = [["id"]]
      },
      {
        name         = "deal_pipelines"
        sync_mode    = "incremental_append"
        cursor_field = ["updatedAt"]
        primary_key  = [["pipelineId"]]
      }
    ]
  }

  schedule = {
    schedule_type = "manual"
  }
}

Any guess if this is a real issue or it is something I am missing?

I am using:

terraform {
  required_providers {
    airbyte = {
      source  = "airbytehq/airbyte"
      version = "0.2.0"
    }
  }
}

But I already tested with versions 0.3.0 and 0.3.5

@ThomasRooney
Copy link
Contributor

FYI I tested this, but couldn't replicate using virtually equivalent terraform specifications. Is this still happening?

The only way I could get a replication was if I'd already changed my remote instance of the streams first (in which case it was reconciled, and didn't detect changes). Might be something with my local setup though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants