Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helm] Support overriding the minio/mc image #34825

Open
Meir017 opened this issue Feb 4, 2024 · 0 comments · May be fixed by airbytehq/airbyte-platform#303
Open

[helm] Support overriding the minio/mc image #34825

Meir017 opened this issue Feb 4, 2024 · 0 comments · May be fixed by airbytehq/airbyte-platform#303
Labels
area/platform issues related to the platform community helm kubernetes team/deployments type/bug Something isn't working

Comments

@Meir017
Copy link

Meir017 commented Feb 4, 2024

Helm Chart Version

0.50.47

What step the error happened?

Other

Revelant information

The image configuration for the minio/mc image is hardcoded here https://github.com/airbytehq/airbyte-platform/blob/a66da101724ca8681577ffaa17bc708c3088be85/charts/airbyte/templates/minio.yaml#L95C1-L96C1

We should provide default image configuration in the values.yaml file, allowing to override the repository and image (same as we have for image: "{{ .Values.minio.image.repository }}:{{ .Values.minio.image.tag }}"

Relevant log output

No response
@Meir017 Meir017 added area/platform issues related to the platform needs-triage type/bug Something isn't working labels Feb 4, 2024
@Meir017 Meir017 linked a pull request Feb 4, 2024 that will close this issue
Open
2 tasks
@marcosmarxm marcosmarxm changed the title Support overriding the minio/mc image [helm] Support overriding the minio/mc image Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/platform issues related to the platform community helm kubernetes team/deployments type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support overriding the minio/mc image Meir017/airbyte-platform
6 participants
@bleonard @timroes @marcosmarxm @davinchia @Meir017 @octavia-squidington-iii