Removing read of knowledge repo config file off default branch of master #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter for init of gitrepository
|
Thanks for the contribution! Will take a look when I get a chance :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569
Description of changeset:
It looks like you're reading the state of the config file of the knowledge repo off of the target branch which is hardcoded to default as master before there's any room to update the preference of what branch to use.
As a simple fix perhaps it's best to read the state of the config for the knowledge repo of whatever the active branch is instead? This alleviates the breakage when there is no master branch to check the file out from in the git of the knowledge repo.
Test Plan:
Tried pytest, tried
bash run_tests.sh, neither worked. I'm not sure if the issues are environmental and I should be using another tool to aid with them.Would love to know how to help further! Figure this is at least a good starting point to help me learn more about your systems.