Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import/newline-after-import and considerComments: true #2714

Open
thernstig opened this issue Jan 20, 2023 · 2 comments
Open

import/newline-after-import and considerComments: true #2714

thernstig opened this issue Jan 20, 2023 · 2 comments

Comments

@thernstig
Copy link

Would using considerComments: true make sense for https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/newline-after-import.md?

@ljharb
Copy link
Collaborator

ljharb commented Jan 20, 2023

I think that's something that individual codebases can opt in to - personally, the comment is a sufficient buffer, but i can understand why it might not be to some.

@thernstig
Copy link
Author

Sounds reasonable, will do that. Thought that maybe you also though it would be a good default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants