Successfully replaced the rule #2757
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Apr 2, 2023
| before: 'always', | ||
| after: 'always', | ||
| }], | ||
| // Require or disallow padding lines between statements |
There was a problem hiding this comment.
Suggested change
| // Require or disallow padding lines between statements | |
| // Require or disallow padding lines between statements |
| @@ -184,12 +184,9 @@ module.exports = { | |||
| // enforces empty lines around comments | |||
| 'lines-around-comment': 'off', | |||
|
|
|||
| // require or disallow newlines around directives | |||
| // https://eslint.org/docs/rules/lines-around-directive | |||
| 'lines-around-directive': ['error', { | |||
There was a problem hiding this comment.
please don't delete an entry, just add the new one
| }], | ||
| // Require or disallow padding lines between statements | ||
| // https://eslint.org/docs/rules/padding-line-between-statements | ||
| 'padding-line-between-statements': 'off', |
There was a problem hiding this comment.
there's a lot of config here that isn't specified. Please include a config that matches the lines-around-directive config we already have.
sandeepvinnu
approved these changes
May 17, 2023
Bazukakape
approved these changes
Jul 24, 2023
huynhdev24
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2689
Duplicate of #2756.