Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react/README.md #2451

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update react/README.md #2451

wants to merge 4 commits into from

Conversation

rahulrk-dev
Copy link

Fix jsx display issue in webpage
https://airbnb.io/javascript/react/#quotes

Fixes #2301

@Alejandrorn13

This comment has been minimized.

Sign in to view
@ljharb
Copy link
Collaborator

ljharb commented Oct 15, 2021 •
edited

I see the issue you’re referencing. Can you link to something that describes how this fixes it? This doesn’t fix it for all the other cases of self-closing elements in the page; is there a more holistic solution?

@rahulrk-dev
Copy link
Author

@ljharb Here's the output for the fix -
https://devtmk.github.io/javascript/react/#quotes

@ljharb
Copy link
Collaborator

ljharb commented Jan 2, 2022

@devtmk i'm confused; https://devtmk.github.io/javascript/react/#quotes has different JSX than https://airbnb.io/javascript/react/#quotes.

There's also highlighting issues here:

and probably a number of other places. It'd be great to figure out a way to fix them all at once, without requiring inline annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alejandrorn13 Alejandrorn13 Alejandrorn13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSX is not displayed correctly in webpage
3 participants
@rahulrk-dev @Alejandrorn13 @ljharb