Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 5.1 support. #64

Open
KelvinJin opened this issue Dec 6, 2019 · 2 comments
Open

Swift 5.1 support. #64

KelvinJin opened this issue Dec 6, 2019 · 2 comments
Assignees
@bryankeller

Comments

@KelvinJin
Copy link

Describe the solution you'd like
Supporting Swift 5.1 so that module stability can be achieved.

Additional context
The current MagazineLayout target is still using Swift 4. This means every time Xcode updates with a newer swift version, we'll have to rebuild MagazineLayout. Updating to Swift 5.1 will make use of the module stability to allow us rebuild only when we really want to.
@bryankeller bryankeller self-assigned this Dec 20, 2019
@jordanekay
Copy link
Contributor

Opened #101 to address this

@jeanetienne
Copy link

Super keen to get that, how can I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryankeller bryankeller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jordanekay @bryankeller @jeanetienne @KelvinJin