Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aiortc rejecting offer with setup=passive against RFC guidance #1087

Closed
Ragsboss opened this issue Apr 25, 2024 · 0 comments · Fixed by #1090
Closed

aiortc rejecting offer with setup=passive against RFC guidance #1087

Ragsboss opened this issue Apr 25, 2024 · 0 comments · Fixed by #1090

Comments

@Ragsboss
Copy link

Repro steps

  1. Have an SDP that has a=setup:passive in it
  2. Create RTCSessionDescription with this sdp and type="offer"
  3. Call pc.setRemoteDescription with above session description

Expected

  1. This succeeds. See RFC spec that states receiver should be prepared for both active and passive as well.

Even though an offerer is required to insert an "SDP" setup attribute with an "actpass" attribute value in initial offers (Section 5.2) and subsequent offers (Section 5.5), the answerer MUST be able to receive initial and subsequent offers with other attribute values, in order to be backward compatible with older implementations that might insert other attribute values in initial and subsequent offers.

Actual

  1. An exception is raised with message "DTLS setup attribute must be 'actpass' for an offer" from __validate_description method

PS: I see this got discussed a bit in #267
fippo added a commit to fippo/aiortc that referenced this issue May 4, 2024
@fippo
Implement handling of non-actpass setup in offers
b57992b 
RFC 8842 updated RFC 5763 to allow a differt setup attribute than
  actpass
in offers which allows for more control of the DTLS role.

See https://issues.webrtc.org/issues/42223106 for additional details

Fixes aiortc#1087
@fippo fippo mentioned this issue May 4, 2024
Merged
fippo added a commit to fippo/aiortc that referenced this issue May 4, 2024
@fippo
Implement handling of non-actpass setup in offers
0b82548 
RFC 8842 updated RFC 5763 to allow a differt setup attribute than
  actpass
in offers which allows for more control of the DTLS role.

See https://issues.webrtc.org/issues/42223106 for additional details

Fixes aiortc#1087
fippo added a commit to fippo/aiortc that referenced this issue May 4, 2024
@fippo
Implement handling of non-actpass setup in offers
1e4b370 
RFC 8842 updated RFC 5763 to allow a differt setup attribute than
  actpass
in offers which allows for more control of the DTLS role.

See https://issues.webrtc.org/issues/42223106 for additional details

Fixes aiortc#1087
fippo added a commit to fippo/aiortc that referenced this issue May 4, 2024
@fippo
Implement handling of non-actpass setup in offers
4c4fa9a 
RFC 8842 updated RFC 5763 to allow a differt setup attribute than
  actpass
in offers which allows for more control of the DTLS role.

See https://issues.webrtc.org/issues/42223106 for additional details

Fixes aiortc#1087
fippo added a commit to fippo/aiortc that referenced this issue May 4, 2024
@fippo
Implement handling of non-actpass setup in offers
1609289 
RFC 8842 updated RFC 5763 to allow a differt setup attribute than
  actpass
in offers which allows for more control of the DTLS role.

See https://issues.webrtc.org/issues/42223106 for additional details

Fixes aiortc#1087
fippo added a commit to fippo/aiortc that referenced this issue May 20, 2024
@fippo
Implement handling of non-actpass setup in offers
15c3610 
RFC 8842 updated RFC 5763 to allow a differt setup attribute than
  actpass
in offers which allows for more control of the DTLS role.

See https://issues.webrtc.org/issues/42223106 for additional details

Fixes aiortc#1087
fippo added a commit to fippo/aiortc that referenced this issue May 20, 2024
@fippo
Implement handling of non-actpass setup in offers
0b40293 
RFC 8842 updated RFC 5763 to allow a differt setup attribute than
  actpass
in offers which allows for more control of the DTLS role.

See https://issues.webrtc.org/issues/42223106 for additional details

Fixes aiortc#1087
jlaine pushed a commit that referenced this issue May 20, 2024
@fippo @jlaine
Implement handling of non-actpass setup in offers
d92adb3 
RFC 8842 updated RFC 5763 to allow a differt setup attribute than
  actpass
in offers which allows for more control of the DTLS role.

See https://issues.webrtc.org/issues/42223106 for additional details

Fixes #1087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement handling of non-actpass setup in offers fippo/aiortc
1 participant
@Ragsboss