Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to deal with a top-fixed nabvbar #140

Open
shaharsol opened this issue Dec 5, 2019 · 7 comments
Open

How to deal with a top-fixed nabvbar #140

shaharsol opened this issue Dec 5, 2019 · 7 comments
Milestone

Comments

@shaharsol
Copy link

Steps to reproduce:

  1. add a position:fixed;top:0;z-index:1000 navigation bar to the page layout (very popular with mobile design)

What happens: the smartbanner hides below the navbar instead of pushing it down

What should happen: the smaetbanner should push the navbar down

@ain
Copy link
Owner

ain commented Dec 18, 2019

Thanks for the report!

I'd imagine we need to refactor the current jQuery Mobile oriented behaviour for anything that behaves similarly. So instead of worrying about framework we'd be running, we'd actually check for the individual case.

Your PR for this improvement is welcome!

@saranshkataria
Copy link

saranshkataria commented Jan 13, 2020

I used a temporary fix in CSS:

.smartbanner {
  top: -84px;
}

@Huppys
Copy link

Huppys commented Jul 23, 2020

Thanks for the report!

I'd imagine we need to refactor the current jQuery Mobile oriented behaviour for anything that behaves similarly. So instead of worrying about framework we'd be running, we'd actually check for the individual case.

Your PR for this improvement is welcome!

@ain: I thought to give it a shot for a PR, so would you like to review?

@ain
Copy link
Owner

ain commented Jul 23, 2020

Brilliant, thanks a lot @Huppys for the great PR! I've just reviewed it as well, please check once you have time.

@ain ain removed the help wanted label Jul 27, 2020
@ain ain added this to the 2.0.0 milestone Nov 12, 2020
@bminner
Copy link

bminner commented Feb 24, 2021

@ain Is there a reason that this is not merge into the master branch?

@ain
Copy link
Owner

ain commented Mar 13, 2021

@bminner it introduces breaking changes which is why it is designated for v2.0.0 release (the milestone attached).

@kernokus
Copy link

kernokus commented Feb 19, 2023

When is the 2.0.0 release planned ?
I also wanted to ask - how to solve this problem with the side navigation panels that also have position:fixed and top: 54px, for example?
What ways do you see to solve this problem?

vmstukalov added a commit to vmstukalov/smartbanner.js that referenced this issue Dec 14, 2023
Added one of the few handling cases for pages with fixed nav bar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants