Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with running this on windows #6

Open
DanielFatkic opened this issue May 13, 2014 · 2 comments
Open

Problem with running this on windows #6

DanielFatkic opened this issue May 13, 2014 · 2 comments
Labels

Comments

@DanielFatkic
Copy link

I can't get this running on windows:(

It's working from the console , but when i call it from the browser, the filename is wrong
bug

@aik099
Copy link
Owner

aik099 commented May 13, 2014

It looks like some kind of escaping problem. In the browser you have escaped url (e.g. through rawurlencode function). But in console you're giving correct url (without escaping). I guess giving escaped url in console will also fail.

Try using rawurldecode function (e.g. this one http://phpjs.org/functions/rawurldecode/) in the run_editor.js file on the received url before passing it to regexp.

If that will work, then don't forget to send a PR with a fix.

@aik099 aik099 added the bug label May 13, 2014
@aik099
Copy link
Owner

aik099 commented May 13, 2014

It appears that PR #1 author also found similar escaping problem in Mac version of the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants