{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":94891064,"defaultBranch":"main","name":"aiida-quantumespresso","ownerLogin":"aiidateam","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-06-20T12:54:43.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/22181836?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716385728.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"0a40d5a50429f9b34432259de788735385a3ce52","ref":"refs/heads/fix/945-if-requested-do-not-produce-output-data","pushedAt":"2024-05-22T13:48:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yakutovicha","name":"Aliaksandr Yakutovich","path":"/yakutovicha","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13118485?s=80&v=4"},"commit":{"message":"Add parse_retrieved_files option for the PP plugin.\n\nThe option enables switching on/off the parsing of the output files\nproduced by the PP plugin.","shortMessageHtmlLink":"Add parse_retrieved_files option for the PP plugin."}},{"before":"7b6c210a80942aed8ed08fa78f0d123d3227e750","after":"210c40bbc3445f55155bbb855d320afa00fa347e","ref":"refs/heads/main","pushedAt":"2024-05-02T14:06:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"superstar54","name":"Xing Wang","path":"/superstar54","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11457659?s=80&v=4"},"commit":{"message":"`get_xspectra_structures`: Refactor and Improve Code (#1026)\n\nThis PR refactors the `get_xspectra_structures` calcfunction to enable users to set symmetry data manually\r\ninstead of relying on automatic symmetry analysis.\r\n* Moves supercell creation, processes for molecules, and generation of  `equivalent_sites_data` to separate functions.\r\n* Adds functionality for users to manually provide symmetry data, thus enabling the `CalcFunction` to be used as a means to generate structures with user control over which exact sites to mark.\r\n* Fixes a bug discovered in the case where non-hubbard structures with custom Kind names lost their Kind names when converting the ASE supercell to `StructureData` type.\r\n* Fixes a small oversight in the tests where `spglib_settings` was mistakenly named `spglib_options`.","shortMessageHtmlLink":"<code>get_xspectra_structures</code>: Refactor and Improve Code (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2269409773\" data-permission-text=\"Title is private\" data-url=\"https://github.com/aiidateam/aiida-quantumespresso/issues/1026\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/aiidateam/aiida-quantumespresso/pull/1026/hovercard\" href=\"https://github.com/aiidateam/aiida-quantumespresso/pull/1026\">#1026</a>)"}},{"before":"a06c26c58da26cb30594352981e453e4aebc7656","after":null,"ref":"refs/heads/release/4.6.0","pushedAt":"2024-04-23T07:28:35.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"}},{"before":"f4395048dfb9c74b97a5d38eff99029449816dc0","after":"7b6c210a80942aed8ed08fa78f0d123d3227e750","ref":"refs/heads/main","pushedAt":"2024-04-23T07:28:34.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"},"commit":{"message":"🚀 Release `v4.6.0`","shortMessageHtmlLink":"🚀 Release <code>v4.6.0</code>"}},{"before":null,"after":"a06c26c58da26cb30594352981e453e4aebc7656","ref":"refs/heads/release/4.6.0","pushedAt":"2024-04-23T06:54:34.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"},"commit":{"message":"Release `v4.6.0`","shortMessageHtmlLink":"Release <code>v4.6.0</code>"}},{"before":"75ab49051ddb46039eeead40c9a74b5907af9365","after":"f6623b0cd2c28e8b0392ba0cfebf444b92547469","ref":"refs/heads/feat/pop-overrides","pushedAt":"2024-03-29T19:49:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bastonero","name":"Lorenzo","path":"/bastonero","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79980269?s=80&v=4"},"commit":{"message":"Feat: pop None inputs specified in overrides\nFixes #653\n\nAdd the possibility of popping input namespaces by specifying\nNone in the override for the specific namespace. A decorator\nis added that generalize the concept to any implementation of\nget_builder_from_protocol.","shortMessageHtmlLink":"Feat: pop None inputs specified in overrides"}},{"before":"cc5ea0259d97cb68033ce50b173754486d23e4af","after":"75ab49051ddb46039eeead40c9a74b5907af9365","ref":"refs/heads/feat/pop-overrides","pushedAt":"2024-03-29T19:20:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bastonero","name":"Lorenzo","path":"/bastonero","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79980269?s=80&v=4"},"commit":{"message":"Feat: pop None inputs specified in overrides\nFixes #653\n\nAdd the possibility of popping input namespaces by specifying\nNone in the override for the specific namespace. A decorator\nis added that generalize the concept to any implementation of\nget_builder_from_protocol.","shortMessageHtmlLink":"Feat: pop None inputs specified in overrides"}},{"before":"ae7d2484a084ca55dcef4c1ca332b2fb0b478fad","after":"f4395048dfb9c74b97a5d38eff99029449816dc0","ref":"refs/heads/main","pushedAt":"2024-03-29T06:49:05.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"superstar54","name":"Xing Wang","path":"/superstar54","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11457659?s=80&v=4"},"commit":{"message":"XAS: Enable Correct Parsing of Hubbard and Magnetic Data (#969)\n\n* Enable Hubbard and Magnetic Moments for `XspectraCoreWorkChain` and `get_xspectra_structures`\r\n\r\nThis commit enables `XspectraCoreWorkChain` and\r\n`get_xspectra_structures` to correctly parse `HubbardStructureData`\r\nand magnetic moments.\r\n\r\nCurrently enabled:\r\n* `get_xspectra_structures` will preserve Hubbard data if the input\r\n  structure is `HubbardStructureData` node type and scale parameters to\r\nmatch those required for the final supercell.\r\n* the `get_builder_from_protocol` function of `XspectraCoreWorkChain`\r\n will accept `initial_magnetic_moments` as an optional input and pass\r\nthis information to the `scf` namespace.\r\n\r\n\r\n* Tests: Fix minor errors in tests from previous commit\r\n\r\n* `get_xspectra_structures()`: Fix handling of marked structures\r\n\r\nUpdates `get_xspectra_structures()` to retrieve and re-apply Kind\r\ndata to output structures so that Kind names are kept. The function will\r\nnow also correctly determine the list of inequivalent atom sites if\r\n`standardize_structure = False` and return the correct set of marked\r\nstructures.\r\n\r\n* `get_xspectra_structures()`: remove options for `initial_magnetization`\r\n\r\nRemoves options for `initial_magnetization` from the function, since\r\nthis has been shown to be superfluous in practice.\r\n\r\n* `XspectraCrystalWorkChain`: Enable Hubbard and Magnetic Data\r\n\r\nThis commit fully enables the `XspectraCrystalWorkChain` to work with\r\n`HubbardStructureData` and to apply `initial_magnetic_moments` to all\r\nsub-processes. Automatically sets `standardize_structure` to `False` in\r\nthe `get_xspectra_structures` step of the `WorkChain` if the input\r\nstructure is `HubbardStructureData` as required by the `CalcFunction`.\r\n\r\nAlso updates `get_xspectra_structures` with a new optional parameter\r\n`use_element_types` which instructs the `CalcFunction` to treat all\r\n`Kinds` of the same element as the same for the purposes of symmetry\r\nanalysis even if the `kind_name`s are different. Defaults to `False`.\r\n\r\n* `XspectraCrystalWorkChain`: Fix handling of GIPAW pseudos\r\n\r\nUpdates the `run_all_xspectra_core` step in the `XspectraCrystalWorkChain`\r\nto correctly assign the GIPAW pseudo provided for the element to all\r\n`Kind`s corresponding to the element, retaining the step to remove the\r\nGIPAW pseudo if there is only one atom of the absorbing element present\r\nin the structure (and thus, to avoid a crash due to incorrect pseudo\r\nallocation).\r\n\r\n* XSpectra `WorkChain`s: Refinements and Improvements\r\n\r\nAddresses requested changes in PR #969 and refines the logic for\r\nassigning magnetic states to the absorbing atom depending on chosen\r\ncore-hole treatment type, as some oversights were made in the case of\r\nmagnetic systems. The absorbing atom is now always given a spin of 1\r\nif it was 0 in the neutral system and we are using an XCH-type treatment.\r\nOtherwise, the spin is set to the value of its inherited `Kind`.\r\n\r\nOther refinements:\r\n* Fixed a typo where the core-hole treatments would override the\r\noverrides dictionary (the opposite to intended behaviour).\r\n* Removed unnecessary options for SpinType and initial_magnetic_moments\r\nin the `CoreWorkChain`.\r\n* Added tests for `get_xspectra_structures` to cover basic behaviour and\r\ncorrect handling of HubbardStructureData.\r\n\r\n* `get_xspectra_structures`: Bugfixes and Improvements\r\n\r\nChanges:\r\n* Fixes a bug where, if `use_element_types = True`, the symmetry data of\r\nthe \"non-cleaned\" structure would be erroneously returned in\r\n`output_parameters`\r\n* Fixes a bug where, if `use_element_types = True`, the `kind_name` for\r\neach entry in `equivalent_sites_data` would be reported incorrectly.\r\n* Changes the default setting of `use_element_types` to `True`.\r\n* Changes the logic for converting the atomic number of each `type` in\r\n`spglib_tuple` used to generate the `cleaned_structure_tuple` to use\r\n`np.trunc(int()) instead of just `int()`.\r\n\r\n* Tests: Update `test_get_xspectra_structures`\r\n\r\nUpdates `test_use_element_types` following changes to default function\r\nbehaviour introduced in previous commit\r\n(c4701b3c4ba40978a9f40725cab5ca89b94ed74d)\r\n\r\n* `get_xspectra_structures`: Consolidate Logic\r\n\r\nRemoves various unneeded `if` statements and re-uses information\r\ngenerated during the process flow to simplify steps.\r\n\r\n* `get_xspectra_structures`: Reduce Use of `get_symmetry_dataset`\r\n\r\nChanges requested for PR #969\r\n\r\nReplaces some uses of `spglib.get_symmetry_dataset` with a single\r\nfunction call.","shortMessageHtmlLink":"XAS: Enable Correct Parsing of Hubbard and Magnetic Data (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1906614186\" data-permission-text=\"Title is private\" data-url=\"https://github.com/aiidateam/aiida-quantumespresso/issues/969\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/aiidateam/aiida-quantumespresso/pull/969/hovercard\" href=\"https://github.com/aiidateam/aiida-quantumespresso/pull/969\">#969</a>)"}},{"before":"27a95c173cb496853a005d0518ed0cdc7bdd196f","after":"cc5ea0259d97cb68033ce50b173754486d23e4af","ref":"refs/heads/feat/pop-overrides","pushedAt":"2024-03-28T22:31:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bastonero","name":"Lorenzo","path":"/bastonero","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79980269?s=80&v=4"},"commit":{"message":"Feat: pop None inputs specified in overrides\nFixes #653\n\nAdd the possibility of popping input namespaces by specifying\nNone in the override for the specific namespace. A decorator\nis added that generalize the concept to any implementation of\nget_builder_from_protocol.","shortMessageHtmlLink":"Feat: pop None inputs specified in overrides"}},{"before":null,"after":"27a95c173cb496853a005d0518ed0cdc7bdd196f","ref":"refs/heads/feat/pop-overrides","pushedAt":"2024-03-28T22:30:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bastonero","name":"Lorenzo","path":"/bastonero","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79980269?s=80&v=4"},"commit":{"message":"Feat: pop None inputs specified in overrides\n\nAdd the possibility of popping input namespaces by specifying\nNone in the override for the specific namespace. A decorator\nis added that generalize the concept to any implementation of\nget_builder_from_protocol.","shortMessageHtmlLink":"Feat: pop None inputs specified in overrides"}},{"before":"5a6529f46fa3519f006527c02db3a065f6e5ebaa","after":"ae7d2484a084ca55dcef4c1ca332b2fb0b478fad","ref":"refs/heads/main","pushedAt":"2024-03-27T18:32:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sphuber","name":"Sebastiaan Huber","path":"/sphuber","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6992332?s=80&v=4"},"commit":{"message":"`PwBandsWorkChain`: Respect `bands_kpoints` in overrides (#1021)\n\nThe `bands_kpoints` wasn't be respected if specified in the overrides and\r\npassed to the `PwBandsWorkChain.get_builder_from_protocol`.","shortMessageHtmlLink":"<code>PwBandsWorkChain</code>: Respect <code>bands_kpoints</code> in overrides (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2211400119\" data-permission-text=\"Title is private\" data-url=\"https://github.com/aiidateam/aiida-quantumespresso/issues/1021\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/aiidateam/aiida-quantumespresso/pull/1021/hovercard\" href=\"https://github.com/aiidateam/aiida-quantumespresso/pull/1021\">#1021</a>)"}},{"before":"5c3c3012c36577cc0ca6a4374fd97f2ce3177ebe","after":"5a6529f46fa3519f006527c02db3a065f6e5ebaa","ref":"refs/heads/main","pushedAt":"2024-03-27T14:52:31.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bastonero","name":"Lorenzo","path":"/bastonero","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79980269?s=80&v=4"},"commit":{"message":"`PhCalculation`: add symmetry related exit codes\n\nFixes #1001\r\n\r\nSome symmetry errors that ph.x can stop with are added. They are related\r\nto how the PHonon code handles internally symmetry, which unfortunately\r\nis slightly different from the PW code, which is used as a necessary\r\nprevious step to run ph.x. This is generally due to some interal hard-coded\r\nthresholds. The solution is generally to run pw.x by specifying the lattice\r\nspecific ibrav, instead of the more general ibrav=0. This cannot be handled\r\nthough, as it would require to re-run the pw.x code.\r\n\r\nCo-authored-by: Marnik Bercx <mbercx@gmail.com>","shortMessageHtmlLink":"<code>PhCalculation</code>: add symmetry related exit codes"}},{"before":"34406230023c3c3715264a7de180a576fd7def48","after":"5c3c3012c36577cc0ca6a4374fd97f2ce3177ebe","ref":"refs/heads/main","pushedAt":"2024-03-27T13:45:21.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sphuber","name":"Sebastiaan Huber","path":"/sphuber","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6992332?s=80&v=4"},"commit":{"message":"CLI: Add test for data structure import (#1019)","shortMessageHtmlLink":"CLI: Add test for data structure import (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2210805875\" data-permission-text=\"Title is private\" data-url=\"https://github.com/aiidateam/aiida-quantumespresso/issues/1019\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/aiidateam/aiida-quantumespresso/pull/1019/hovercard\" href=\"https://github.com/aiidateam/aiida-quantumespresso/pull/1019\">#1019</a>)"}},{"before":"b7f17cfaf71e5b07089426a4fbe7ae2ca5317523","after":"34406230023c3c3715264a7de180a576fd7def48","ref":"refs/heads/main","pushedAt":"2024-03-27T11:14:21.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"sphuber","name":"Sebastiaan Huber","path":"/sphuber","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6992332?s=80&v=4"},"commit":{"message":"CLI: Fix import of `StructureData` from QE input file (#1018)\n\nThe click option already returns a file handle, so the command\r\nitself should not try to open it again, which excepts.","shortMessageHtmlLink":"CLI: Fix import of <code>StructureData</code> from QE input file (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2210231073\" data-permission-text=\"Title is private\" data-url=\"https://github.com/aiidateam/aiida-quantumespresso/issues/1018\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/aiidateam/aiida-quantumespresso/pull/1018/hovercard\" href=\"https://github.com/aiidateam/aiida-quantumespresso/pull/1018\">#1018</a>)"}},{"before":"9cb1cfa8a70d19af7aaa1b624cf17c8babe93f41","after":"b7f17cfaf71e5b07089426a4fbe7ae2ca5317523","ref":"refs/heads/main","pushedAt":"2024-03-19T14:19:45.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"superstar54","name":"Xing Wang","path":"/superstar54","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11457659?s=80&v=4"},"commit":{"message":"Fix inputs for molecules in the XPS calculation (#1013)\n\nIf it is a molecular structure:\r\n* Adds the 'mt' to `ch_scf` in order to treat charged molecular systems\r\n* Performs the SCF calculations at Gamma point.\r\n\r\n---------\r\n\r\nCo-authored-by: Xing Wang <xingwang1991@gmail.com>","shortMessageHtmlLink":"Fix inputs for molecules in the XPS calculation (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2156351359\" data-permission-text=\"Title is private\" data-url=\"https://github.com/aiidateam/aiida-quantumespresso/issues/1013\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/aiidateam/aiida-quantumespresso/pull/1013/hovercard\" href=\"https://github.com/aiidateam/aiida-quantumespresso/pull/1013\">#1013</a>)"}},{"before":"d645069d1d6ac40d6a23e4bbf49b01b51f5bb33c","after":"9cb1cfa8a70d19af7aaa1b624cf17c8babe93f41","ref":"refs/heads/main","pushedAt":"2024-02-19T13:56:25.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"},"commit":{"message":"`seekpath_structure_analysis`: `HubbardStructureData` compatibility\n\nThe current implementation of the `seekpath_structure_analysis` calculation function\r\nis not compatible with the `HubbardStructureData` data class. Although the function runs\r\nwithout errors, the returned primitive structure is now simply a `StructureData`\r\ninstance, and hence we lose all information related to the Hubbard parameters.\r\n\r\nHere we adapt the `seekpath_structure_analysis` calculation function so that it checks\r\nif the provided input `structure` is a `HubbardStructureData` instance. If so, the\r\nresulting primitive and conventional structures are converted into\r\n`HubbardStructureData` instances with the same _onsite_ Hubbard parameters as the input\r\nstructure.\r\n\r\nIntersite parameters are much more challenging to preserve correctly when primitivizing\r\nthe structure, since they cannot simply be defined in terms of the kinds of the\r\nstructure. Rather, they are defined on pairs of site indices and transations, which the\r\n`get_explicit_kpoints_path` does not consider when primitivizing the structure. Hence,\r\nthe `seekpath_structure_analysis` function currently does not support intersite\r\nparameters and will raise if the input `structure` has any defined.\r\n\r\nCo-authored-by: AndresOrtegaGuerrero <34098967+AndresOrtegaGuerrero@users.noreply.github.com>","shortMessageHtmlLink":"<code>seekpath_structure_analysis</code>: <code>HubbardStructureData</code> compatibility"}},{"before":"ef961e4ef100d4ef36cf87ecce2f7ecee271b7b3","after":"d645069d1d6ac40d6a23e4bbf49b01b51f5bb33c","ref":"refs/heads/main","pushedAt":"2024-02-13T11:06:54.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"},"commit":{"message":"`HubbardStructureData`: add compatibility for <3D structures\n\nThe `HubbardStructureData.append_hubbard_parameter()` method currently fails for\nstructures that don't have 3-dimensional periodic boundary conditions. This is caused\nby a restriction in the StructureData.get_pymatgen_structure()` method, which raises a\n`ValueError` if the periodic boundary conditions are not (True, True, True). This has\nbeen fixed in a recent commit on `aiida-core`:\n\nhttps://github.com/aiidateam/aiida-core/commit/adcce4bcd0b59c8371be73058a060bedcaba40f6\n\nBut this will take some time to be released and would restrict our compatibility to\n`aiida-core>=2.6.0`.\n\nHere we directly construct a list of `PeriodicSite` objects from the `sites` list of the\nobject obtained from `StructureData.get_pymatgen()`, which can be both either a\npymatgen `Structure` or `Molecule`, depending on the dimensionality of the structure.\n\nCo-authored-by: AndresOrtegaGuerrero <34098967+AndresOrtegaGuerrero@users.noreply.github.com>","shortMessageHtmlLink":"<code>HubbardStructureData</code>: add compatibility for &lt;3D structures"}},{"before":"599a3181bca35d59bc2077061830245d7bd33973","after":null,"ref":"refs/heads/release/4.5.1","pushedAt":"2024-02-13T10:34:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"}},{"before":"b65962565f300fbda643ea43d18d01329c4a85ff","after":"ef961e4ef100d4ef36cf87ecce2f7ecee271b7b3","ref":"refs/heads/main","pushedAt":"2024-02-13T10:34:22.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"},"commit":{"message":"🚀 Release `v4.5.1`","shortMessageHtmlLink":"🚀 Release <code>v4.5.1</code>"}},{"before":"15bb51f215551083f57a311ed885911c71674bd1","after":"599a3181bca35d59bc2077061830245d7bd33973","ref":"refs/heads/release/4.5.1","pushedAt":"2024-02-13T10:23:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"},"commit":{"message":"🚀 Release `v4.5.1`","shortMessageHtmlLink":"🚀 Release <code>v4.5.1</code>"}},{"before":"763eff933e8fc306ad4dd58b0d7f7f2f40f253da","after":"15bb51f215551083f57a311ed885911c71674bd1","ref":"refs/heads/release/4.5.1","pushedAt":"2024-02-13T10:22:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"},"commit":{"message":"🚀 Release `v4.5.1`","shortMessageHtmlLink":"🚀 Release <code>v4.5.1</code>"}},{"before":null,"after":"763eff933e8fc306ad4dd58b0d7f7f2f40f253da","ref":"refs/heads/release/4.5.1","pushedAt":"2024-02-13T10:02:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"},"commit":{"message":"🚀 Release `v4.5.1`","shortMessageHtmlLink":"🚀 Release <code>v4.5.1</code>"}},{"before":"32536e85abd6de30cd8f9a07124996ce8cd0760a","after":"b65962565f300fbda643ea43d18d01329c4a85ff","ref":"refs/heads/main","pushedAt":"2024-02-13T09:49:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"},"commit":{"message":"📚 `CHANGELOG.md`: improve release notes for `v4.5.0`\n\nThe release notes of `v4.5.0` did not add any explanation of the main changes\r\nand some useful code snippets. Since there was actually a breaking change\r\nrelated to how q-points are defined for the `PhBaseWorkChain`, adding some\r\nnotes (that can then be copied to the documentation) is useful.\r\n\r\nMoreover, the subsections for the full list of changes did not respect the same\r\norder as previous release notes, which offended the OCD of one of the more\r\npicky and annoying developers. Hence, we correct this egregious error, and also\r\nadd a specific section to put commits that only affect tests.","shortMessageHtmlLink":"📚 <code>CHANGELOG.md</code>: improve release notes for <code>v4.5.0</code>"}},{"before":"c353cc2e4104352ef9b5490adb53a60da47f293d","after":"32536e85abd6de30cd8f9a07124996ce8cd0760a","ref":"refs/heads/main","pushedAt":"2024-02-12T17:49:32.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"},"commit":{"message":"`PhBaseWorkChain`: skip q-points validation if ports are excluded\n\nCurrently, the top-level `validate_inputs` validator for the `PhBaseWorkChain` will\r\nalways check if either the `qpoints` or `qpoints_distance` inputs are provided. However,\r\nthere are cases where a higher-level work chain that wraps the `PhBaseWorkChain` might\r\nprovide the q-points input on the fly. Such a work chain would have to set the\r\n`PhBaseWorkChain` validator to `None` in its own `define` method.\r\n\r\nHowever, as also discussed for a similar case for the `PwCalculation` in a389629,\r\nit's more elegant to check if the `qpoints_distance` and `qpoints` ports are present in\r\nthe namespace. Typically a work chain that provides the q-points input on the fly will\r\nexclude these ports when exposing the `PhBaseWorkChain` inputs. By checking if the ports\r\nare present in the validator, we avoid having to set the validator to `None` as well in\r\nthe higher-level work chain.","shortMessageHtmlLink":"<code>PhBaseWorkChain</code>: skip q-points validation if ports are excluded"}},{"before":"a09afe5818cd6399ff37f8338b28a160141fcfbf","after":null,"ref":"refs/heads/fix/ph/set-qpoints","pushedAt":"2024-02-12T10:22:12.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"}},{"before":"b517686df8cd33765ef12cbf430620ea8e94f137","after":"c353cc2e4104352ef9b5490adb53a60da47f293d","ref":"refs/heads/main","pushedAt":"2024-02-12T10:22:11.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mbercx","name":"Marnik Bercx","path":"/mbercx","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25607960?s=80&v=4"},"commit":{"message":"`PhBaseWorkChain`: fix `set_qpoints` step\n\nThe `set_qpoints` step in the outline of the `PhBaseWorkChain` contained several errors\r\nincorrectly assuming that the inputs of the `PhCalculation` are found in the\r\n`self.ctx.inputs.ph` namespace of the context. These should actually be placed in the\r\n`self.ctx.inputs`, which is where the `BaseRestartWorkChain` expects to find the inputs\r\nof the process class it wraps. Here we correctly assign the inputs in the context.\r\n\r\n`Additionally, the `set_qpoints` step would assume that the `qpoints_force_parity` input\r\nof the PhBaseWorkChain is always present. However, this is not a required input, and\r\nhence we take this in consideration in the `set_qpoints` logic.","shortMessageHtmlLink":"<code>PhBaseWorkChain</code>: fix <code>set_qpoints</code> step"}},{"before":"b264936e24999bb75d889aedd430009972986337","after":"a09afe5818cd6399ff37f8338b28a160141fcfbf","ref":"refs/heads/fix/ph/set-qpoints","pushedAt":"2024-02-11T20:10:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bastonero","name":"Lorenzo","path":"/bastonero","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79980269?s=80&v=4"},"commit":{"message":"Update docstring","shortMessageHtmlLink":"Update docstring"}},{"before":"d6f569658ba20eb76c5016ad76398d95aa29adac","after":"b264936e24999bb75d889aedd430009972986337","ref":"refs/heads/fix/ph/set-qpoints","pushedAt":"2024-02-11T15:33:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bastonero","name":"Lorenzo","path":"/bastonero","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79980269?s=80&v=4"},"commit":{"message":"Fix tests","shortMessageHtmlLink":"Fix tests"}},{"before":null,"after":"d6f569658ba20eb76c5016ad76398d95aa29adac","ref":"refs/heads/fix/ph/set-qpoints","pushedAt":"2024-02-11T15:19:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bastonero","name":"Lorenzo","path":"/bastonero","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79980269?s=80&v=4"},"commit":{"message":"Bug: `PhBaseWorkChain.set_qpoints` doesn't work\n\nThe `set_qpoints` method was untested and contained\nmany typos and bugs, which would break the usage of\nthe workchain when a `qpoints_distance` is used and\nwould set wrong `qpoints` in the context inputs.","shortMessageHtmlLink":"Bug: <code>PhBaseWorkChain.set_qpoints</code> doesn't work"}},{"before":"2c5bd251e4ac0314d6a3e9c31bed84f857c24edd","after":null,"ref":"refs/heads/release/4.5.0","pushedAt":"2024-01-24T19:03:44.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"sphuber","name":"Sebastiaan Huber","path":"/sphuber","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6992332?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUP8PXgA","startCursor":null,"endCursor":null}},"title":"Activity · aiidateam/aiida-quantumespresso"}