Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiidalab uninstall does not remove the AiiDALab app package installed by pip #405

Open
unkcpz opened this issue Jan 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@unkcpz
Copy link
Member

unkcpz commented Jan 23, 2024

In the test, the aiidalab-widgets-base is installed by aiidalab install and uninstall with aiidalab uninstall. It will cause the problem that the app is deleted but the package still in the python path. Which potentially lead to the fail of pip check, when the aiidalab-widgets-base has newer version i.e 2.2.0 but not yet bump in aiidalab-qe i.e 2.1.0.
It will result the: "aiidalab-qe 23.10.x has requirement aiidalab-widgets-base==2.1.0, but you have aiidalab-widgets-base 2.2.0."

It caused from aiidalab uninstall only move the app to trash but not run pip uninstall, so the fixture generate_aiidalab_install_output is not roll back the environment.

The ultimate solution is install the awb from pip install since it will no more be the app (aiidalab/aiidalab-widgets-base#550).

@danielhollas
Copy link
Contributor

Hmm, interesting issue. I think this should actually be fixed in the aiidalab package so that aiidalab uninstall also removes the built package (e.g. aiidalab-qe. (the other dependencies of the app will still be there, but I am not sure we have a good solution for that).

@unkcpz if you agree let's move the issue there.

@danielhollas danielhollas changed the title Test on installation of aiidalab-widgets-base should not install by aiidalab install aiidalab uninstall does not remove the package of the AiiDALab app Feb 3, 2024
@danielhollas danielhollas changed the title aiidalab uninstall does not remove the package of the AiiDALab app aiidalab uninstall does not remove the AiiDALab app package installed by pip Feb 9, 2024
@danielhollas danielhollas transferred this issue from aiidalab/aiidalab-docker-stack Feb 9, 2024
@danielhollas danielhollas added the bug Something isn't working label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants