Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguity if the installed app is also a dependency #378

Open
unkcpz opened this issue Mar 19, 2023 · 0 comments
Open

Ambiguity if the installed app is also a dependency #378

unkcpz opened this issue Mar 19, 2023 · 0 comments

Comments

@unkcpz
Copy link
Member

unkcpz commented Mar 19, 2023

This is a design issue rather than a bug if a registered app is installed and it is also installed as a dependency of another app. This is now only happening on aiidalab-widgets-base.
The installed version is detected from the local repo either by version in registered list or by the version in "setup.cfg" as defined in

def installed_version(self) -> AppVersion | str:
. If another app has this app in their dependencies list, the app will be installed through pip again. It leads to two scenarios:

  1. if the app is installed first (let's say AWB-2.0.0a2), the pip install of it as a dependency will override it (let's say qeapp install awb-2.0.0a1 ), which makes in the app manager the version of app shown is 2.0.0a2 which pip freeze shows the awb version in use is 2.0.0a1.
  2. if the app is installed after, it will be all fine that the installed version shown in app manager is conformed with the pip list.

One option I want to propose is to prevent them from app installing other apps as a dependency, this is easy to detect by comparing the dependencies list in terms of the register app list, and in design makes a lot of sense to me. The problem is we have AWB which is going to be deprecated as an app that is a strong dependency of many other app. Removing it from the app registry will be the first step to move forward.

pinning @yakutovicha @danielhollas for comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant