Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make installation workflow more robust #364

Open
danielhollas opened this issue Mar 6, 2023 · 1 comment
Open

Make installation workflow more robust #364

danielhollas opened this issue Mar 6, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@danielhollas
Copy link
Contributor

The brittleness of the installation workflow partly comes from the fact that the app is installed before the dependencies. That is not common. Pip and conda do exactly the opposite. They first install the dependencies, and only then proceed with installing the main package.

I am thinking that reverting the order might solve a lot of things for us too.

We need to pull the folder to a temporary location (already implemented) and install dependencies(already implemented). If that was successful - copy the folder to ~/apps. It is really about reshuffling the code a tiny bit.

Originally posted by @yakutovicha in #349 (comment)

@danielhollas danielhollas added the enhancement New feature or request label Mar 6, 2023
@danielhollas danielhollas added this to the v23.10 milestone Mar 6, 2023
@danielhollas
Copy link
Contributor Author

Just to illustrate the importance of this, I was able to trigger the installation of an App twice by clicking the Install button twice in rapid succession.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant