packaging==22.0 breaks aiidalab install

[danielhollas]

Package packaging version 22.0 breaks the aiidalab install command. Here's what I see

$ aiidalab install aiidalab-widgets-base==2.0.0b0
Collecting apps matching requirements... /
Traceback (most recent call last):
  File "/opt/conda/envs/aiida-base/bin/aiidalab", line 10, in <module>
    sys.exit(cli())
  File "/opt/conda/envs/aiida-base/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/opt/conda/envs/aiida-base/lib/python3.9/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/opt/conda/envs/aiida-base/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/conda/envs/aiida-base/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/conda/envs/aiida-base/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/opt/conda/envs/aiida-base/lib/python3.9/site-packages/aiidalab/__main__.py", line 399, in install
    install_candidates = {
  File "/opt/conda/envs/aiida-base/lib/python3.9/site-packages/aiidalab/__main__.py", line 400, in <dictcomp>
    requirement: _find_version_to_install(
  File "/opt/conda/envs/aiida-base/lib/python3.9/site-packages/aiidalab/__main__.py", line 297, in _find_version_to_install
    matching_releases = app.find_matching_releases(
  File "/opt/conda/envs/aiida-base/lib/python3.9/site-packages/aiidalab/app.py", line 225, in find_matching_releases
    specifier.filter(self.releases or [], prereleases=prereleases)
  File "/opt/conda/envs/aiida-base/lib/python3.9/site-packages/packaging/specifiers.py", line 979, in filter
    parsed_version = _coerce_version(item)
  File "/opt/conda/envs/aiida-base/lib/python3.9/site-packages/packaging/specifiers.py", line 25, in _coerce_version
    version = Version(version)
  File "/opt/conda/envs/aiida-base/lib/python3.9/site-packages/packaging/version.py", line 197, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
packaging.version.InvalidVersion: Invalid version: 'stable'

Downgrading to version 21.3 fixes the issue. We need to either constrain the version in setup.cfg or fix the underlying issue.

Note, in the current docker-stack this is not an issue since packaging is already installed in the underlying jupyter image. But as soon as they update we will break.

[danielhollas]

Hmm, maybe packaging isn't to blame after all. I am playing with conda environments, perhaps I am doing something wrong...

EDIT: Nope, it's definitely packaging. I think aiidalab uses some non-standard version labels which results in breakage.

[yakutovicha]

Should we switch to flit? Happy to open a PR for that.

[UPDATE]
Oh, sorry - this is for the aiidalab functionality, not for the installation of AiiDAlab. Nevertheless, I think it makes sense to move aiidalab to flit.

[danielhollas]

Not sure what you mean? The issue here is not with the build. Dne st 14. 12. 2022 8:00 dop. uživatel Aliaksandr Yakutovich < ***@***.***> napsal:

…

Should we switch to flit? — Reply to this email directly, view it on GitHub <#339 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACIY64IW3JBWISJDH67HGHDWNF5DRANCNFSM6AAAAAAS52DFW4> . You are receiving this because you were assigned.Message ID: ***@***.***>

[yakutovicha]

Not sure what you mean? The issue here is not with the build.

Yeah, I realised that later 😅 . That is why I wrote an update:

[UPDATE]
Oh, sorry - this is for the aiidalab functionality, not for the installation of AiiDAlab. Nevertheless, I think it makes sense to move aiidalab to flit.

[danielhollas]

I will re-open this so that we remember to fix this properly (for now we only pinned to the old version of packaging).

[danielhollas]

I think this the same issue as in aiidalab/aiidalab-registry#103