Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic version attribute in setup.cfg #333

Open
danielhollas opened this issue Dec 1, 2022 · 1 comment
Open

Support dynamic version attribute in setup.cfg #333

danielhollas opened this issue Dec 1, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@danielhollas
Copy link
Contributor

In my app's setup.cfg I have version = attr: aiidalab_ispg.__version__, which I believe is valid and pip recognizes it, but aiidalab list says

App name               Version                          Path
---------------------  -------------------------------  ---------------------------------------
aiidalab-ispg          attr: aiidalab_ispg.__version__  /home/jovyan/apps/aiidalab-ispg
@danielhollas danielhollas added the enhancement New feature or request label Dec 1, 2022
@danielhollas
Copy link
Contributor Author

Currently we use configparse.ConfigParser to parse the setup.cfg file.

def _parse_setup_cfg(setup_cfg):

To support dynamic attributes, we can use the setuptools API directly, per
https://stackoverflow.com/a/71276404/3682277

@danielhollas danielhollas self-assigned this Feb 8, 2023
danielhollas referenced this issue in EmpaEconversion/aiidalab-aurora Feb 21, 2023
@danielhollas danielhollas added this to the v23.10 milestone Mar 8, 2023
@danielhollas danielhollas removed their assignment Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant