Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: search should match non-exactly #266

Open
3 tasks
csadorf opened this issue Feb 21, 2022 · 1 comment
Open
3 tasks

CLI: search should match non-exactly #266

csadorf opened this issue Feb 21, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@csadorf
Copy link
Member

csadorf commented Feb 21, 2022

As suggested by @mbercx the aiidalab search function is currently matching only exact app names by default which is likely too restrictive. As a possible improvement, we could

  • match search terms with wildcards, e.g., foo would match as *foo* with the current behavior.
  • Use "fuzzy" matches, e.g., via the Levenshtein Distance
  • Not only search the name, but also other metadata, e.g., the app description.
@csadorf csadorf added the enhancement New feature or request label Feb 21, 2022
@mbercx
Copy link
Member

mbercx commented Feb 21, 2022

Regarding the 3rd suggestion, brew has a --desc option for this. Not sure if we want to do this by default, but perhaps, considering the fact that we don't have that many apps yet. E.g. let's say we rename quantum-espresso to qe. I would still prefer that aiidalab search espresso would still return the qe app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants