Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeTreeWidget: Add input nodes #432

Open
danielhollas opened this issue Feb 20, 2023 · 2 comments
Open

NodeTreeWidget: Add input nodes #432

danielhollas opened this issue Feb 20, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@danielhollas
Copy link
Contributor

danielhollas commented Feb 20, 2023

Currently in the tree, we only show the output nodes in the outputs directory of a given workchain. Sometimes it is very useful for debugging to see exactly how the input nodes look like. Therefore I propose we add the inputs directory.

This should be relatively easy, we just need to generalize the code that adds the output nodes.

class AiidaOutputsTreeNode(TreeNode):

See also corresponding discussion on the QeApp.
aiidalab/aiidalab-qe#352

@danielhollas
Copy link
Contributor Author

@unkcpz any thoughts on this? I think I'd like to tackle this in a relatively near future. I need to solve some performance issues with the NodeTree widget, and this looks like an easier issue to tackle first to get familiar with the widget.

@unkcpz
Copy link
Member

unkcpz commented Jun 27, 2023

That would be great if you can have a look at it! I need to remind the variable naming convention is very nasty in this widget, maybe you can start from standardize it. The "node" of the node tree is confusing with the AiiDA node concept in this widget, which makes it very buggy.

@danielhollas danielhollas self-assigned this Aug 31, 2023
@unkcpz unkcpz modified the milestones: v2.1.0, v2.2.0 Oct 4, 2023
@danielhollas danielhollas modified the milestones: v2.2.0, v0.2.3 Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants