Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a good test for QeAppWorkChain #645

Open
superstar54 opened this issue Mar 21, 2024 · 0 comments
Open

Add a good test for QeAppWorkChain #645

superstar54 opened this issue Mar 21, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@superstar54
Copy link
Member

The old unit test uses a regression test on the final builder generated by the workchain. This is not a good design. Because the plugins depend on other packages, like aiida-quantumespresso, aiida-vibroscopy, and aiida-muon. Thus, the final builder also depends on those packages. In the latest work, we want to bump aside-quantum espresso to 4.5 and aside-core to 2.5, and the test failed because different aiida-quantumespresso produce different builder files.

In #644, I replaced the regression test using the ui_parameters generated by the app. This ui_parameter is the most important parameter. It contains all the information on the job, and one can use it to recreate the whole qeapp instance.

However, we still need a test on the QeAppWorkChain. The test should ideally only focus on the functionality of WorkChain itself.

For tests on the sub-WorkChains, which are related to the built-in plugins (bands, pdos, etc), one should add separate test files. In this way, the tests is clear and modularized.

@superstar54 superstar54 added the enhancement New feature or request label Mar 21, 2024
@superstar54 superstar54 added this to the v2024.10.0 milestone May 1, 2024
@superstar54 superstar54 self-assigned this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant