Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The calculation can fail due to the structure not being sorted #635

Open
JPchico opened this issue Apr 27, 2023 · 0 comments
Open

The calculation can fail due to the structure not being sorted #635

JPchico opened this issue Apr 27, 2023 · 0 comments
Assignees

Comments

@JPchico
Copy link
Collaborator

JPchico commented Apr 27, 2023

Currently if the StructureData node does not have its sites sorted in such a way that atoms are grouped via type this might result in VASP itself crashing. this happens in large supercells

The reason is that if the atoms are not sorted when the program is trying to read the atomic species a check in how long the line can be is reached causing a conflict between the number of atoms and sites.

One could provide a warning for this, in which one could try to detect if the structure is sorted, perhaps this is something for parsevap?

Another thing that could be done is providing a calcfunction that takes the structure and sorts it so that VASP is happy. Then it would be to the user to determine whether or not to use this functionality.

@JPchico JPchico self-assigned this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant