Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smearing inputs in BandsWorkChain #567

Open
lan496 opened this issue Dec 20, 2021 · 0 comments
Open

Smearing inputs in BandsWorkChain #567

lan496 opened this issue Dec 20, 2021 · 0 comments

Comments

@lan496
Copy link
Contributor

lan496 commented Dec 20, 2021

The current BandsWorkChain takes inputs.smearing.(gaussian|sigma) to control ISMEAR and SIGMA.

spec.input('smearing.gaussian', valid_type=get_data_class('bool'), required=False, default=lambda: get_data_node('bool', True))
spec.input('smearing.sigma', valid_type=get_data_class('float'), required=False, default=lambda: get_data_node('float', 0.05))

If I understand correctly, theinputs.smearing namespace is fed to inherit_and_merge_parameters. Then, the same overriding can be archived just by setting Workflow input parameter inputs.parameters.smearing.

parameters = inherit_and_merge_parameters(self.inputs)

I think that moving inputs.smearing to inputs.bands.smearing is more flexible and composable because a higher workchain like MasterWorkChain can control smearing parameters via bands namespace.

I will create PR if it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant