You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I understand correctly, theinputs.smearing namespace is fed to inherit_and_merge_parameters. Then, the same overriding can be archived just by setting Workflow input parameterinputs.parameters.smearing.
I think that moving inputs.smearing to inputs.bands.smearing is more flexible and composable because a higher workchain like MasterWorkChain can control smearing parameters via bands namespace.
I will create PR if it makes sense.
The text was updated successfully, but these errors were encountered:
The current
BandsWorkChain
takesinputs.smearing.(gaussian|sigma)
to controlISMEAR
andSIGMA
.aiida-vasp/aiida_vasp/workchains/bands.py
Lines 31 to 32 in c41eef0
If I understand correctly, the
inputs.smearing
namespace is fed toinherit_and_merge_parameters
. Then, the same overriding can be archived just by setting Workflow input parameterinputs.parameters.smearing
.aiida-vasp/aiida_vasp/workchains/bands.py
Line 143 in c41eef0
I think that moving
inputs.smearing
toinputs.bands.smearing
is more flexible and composable because a higher workchain likeMasterWorkChain
can control smearing parameters viabands
namespace.I will create PR if it makes sense.
The text was updated successfully, but these errors were encountered: