Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New feature] Stop scrolling at page edge #1039

Open
JulioCabria opened this issue Apr 5, 2024 · 0 comments
Open

[New feature] Stop scrolling at page edge #1039

JulioCabria opened this issue Apr 5, 2024 · 0 comments

Comments

@JulioCabria
Copy link

JulioCabria commented Apr 5, 2024

The "problem"

The current behavior is that Sioyek allows scrolling past a page into blank space. This is especially noticeable with PDF documents with landscape pages, like presentations.

You will find that you are able to scroll half a page into a blank space roughly the size of a slide, both past the first slide and also past the last slide into the end of the document.

This is a problem because subsequent page moves you make, especially screen moves, will no longer align correctly. If you set fit page and scroll window to 1, you would never hit a "partial scroll" if it wasnt for this behavior.

A possible solution

This is why I suggest adding a config option, for example limit_scroll_to_pages that makes it so you hit a limit and are unable to scroll or move into white space outside the area of the existing pages.

See images for context:

Suggested behavior.

Scroll "tops out" against the top edge of the first page. (Same for the last page)

image

Current behavior.

Scroll continues into blank space, offsetting all future move commands and making pages no longer align correctly in next-page / previous-page moves

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant