Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML packages produces urlencoded %2f #33

Open
squakez opened this issue May 11, 2021 · 3 comments
Open

HTML packages produces urlencoded %2f #33

squakez opened this issue May 11, 2021 · 3 comments

Comments

@squakez
Copy link
Contributor

squakez commented May 11, 2021

Hi there. We noticed that the output generated is producing a %2f encoded value instead of a /. That's not a problem for a browser but it can be a problem for any tool looking for validity of references. In our case, it can't validate the page because it thinks it misses the links.

<p>Packages:</p>
<ul>
<li>
<a href="#camel.apache.org%2fv1alpha1">camel.apache.org/v1alpha1</a>
</li>
<li>
<a href="#camel.apache.org%2fv1">camel.apache.org/v1</a>
</li>
</ul>
<h2 id="camel.apache.org/v1alpha1">camel.apache.org/v1alpha1</h2>

An easy workaround we're using is to replace the encoded value, so, the check is not failing anymore.

@ahmetb
Copy link
Owner

ahmetb commented May 11, 2021

I think we did that on purpose because the slashes were not working properly (and they're harder to parse in URLs).

@squakez
Copy link
Contributor Author

squakez commented May 12, 2021

Yeah, I think you can consider a minor issue as it does not affect directly the user experience. However I wonder why this %2f is only present in the Packages section and the rest of html document is using normal / in the hrefs.

@ahmetb
Copy link
Owner

ahmetb commented May 12, 2021

argh my memory doesn't serve me as to why we added urlencode. technically you can have id with / and hrefs to that as urlencoded version of it. (see recent PRs/commits) the links should still work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants