Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the invalid master key file error #424

Open
fluca1978 opened this issue Mar 25, 2024 · 8 comments
Open

Improve the invalid master key file error #424

fluca1978 opened this issue Mar 25, 2024 · 8 comments
Assignees
Labels
feature New feature

Comments

@fluca1978
Copy link
Collaborator

In different points of main.c there are errors about the master key file, for example https://github.com/agroal/pgagroal/blob/master/src/main.c#L536.
This can be confusing, since the user is not able to understand what is the problematic file: it could be a different file (e.g., pgagroal_users.conf that cannot be decrypted) or the master key file that does not exists. Moreover, all the errx calls exit with 1, while a more specific return code is probided into ret.
More information should be reported both to systemd and to the user.

@fluca1978 fluca1978 added the feature New feature label Mar 25, 2024
@T1t4m1un
Copy link
Contributor

Could I take on this ticket?~ @fluca1978

@jesperpedersen
Copy link
Collaborator

@T1t4m1un Go for it

@hariharan0905
Copy link

hariharan0905 commented May 4, 2024

Is this issue got fixed!! or other wise can i go for it @jesperpedersen

@jesperpedersen
Copy link
Collaborator

@hariharan0905 @T1t4m1un is currently assigned to it...

@T1t4m1un Update ?

@T1t4m1un
Copy link
Contributor

T1t4m1un commented May 5, 2024

@hariharan0905 @T1t4m1un is currently assigned to it...

@T1t4m1un Update ?

Sorry I forget to update it!!! I'm not at the computer recently, I will update as soon as possible

@fluca1978
Copy link
Collaborator Author

fluca1978 commented May 7, 2024 via email

@jesperpedersen
Copy link
Collaborator

@hariharan0905 Please, work on one issue at the time so we know what is being worked on

@hariharan0905
Copy link

Ok sure!

T1t4m1un added a commit to T1t4m1un/pgagroal that referenced this issue May 7, 2024
T1t4m1un added a commit to T1t4m1un/pgagroal that referenced this issue May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

4 participants