Skip to content

Commit d545023

Browse files
committed
chore: updates for new apply notary requirements
1 parent 252b649 commit d545023

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ jobs:
4242
run: npm run publish
4343
env:
4444
APPLE_IDENTITY: ${{ secrets.APPLE_IDENTITY }}
45-
APPLE_BUNDLE_ID: ${{ secrets.APPLE_BUNDLE_ID }}
4645
APPLE_USER_ID: ${{ secrets.APPLE_USER_ID }}
4746
APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
47+
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
4848
WINDOWS_CERTIFICATE_PASSWORD: ${{ secrets.WINDOWS_CERTIFICATE_PASSWORD }}
4949
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5050
windows:

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ An apple developer certificate is required to sign the application for distribut
3737

3838
1. Add the rest of the environment variables as secrets:
3939
- `APPLE_IDENTITY`: _the name of the developer id certificate name as it appears in keychain_
40-
- `APPLE_BUNDLE_ID`: _the app bundle id (e.g. com.apple.calculator)_
41-
- `APPLE_USER_ID`: _your apple developer id_
42-
- `APPLE_PASSWORD`: _your apple developer password_
40+
- `APPLE_TEAM_ID`: _the team id to notarize under_
41+
- `APPLE_USER_ID`: _the username of your apple developer account_
42+
- `APPLE_PASSWORD`: _the app-specific password (not your Apple ID password)_
4343

4444
## Deploying a new version
4545

forge.config.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,11 @@ const config = {
2525
'entitlements-inherit': 'build/entitlements.plist',
2626
},
2727
osxNotarize: {
28+
tool: 'notarytool',
2829
appBundleId: process.env.APPLE_BUNDLE_ID,
2930
appleId: process.env.APPLE_USER_ID,
3031
appleIdPassword: process.env.APPLE_PASSWORD,
32+
teamId: process.env.APPLE_TEAM_ID,
3133
},
3234
},
3335
makers: [

0 commit comments

Comments
 (0)