Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token regular expression is case sensitive #134

Open
aliomattux opened this issue Nov 17, 2017 · 0 comments
Open

Token regular expression is case sensitive #134

aliomattux opened this issue Nov 17, 2017 · 0 comments

Comments

@aliomattux
Copy link

In the api controller there is a method authorise which checks if the token provided is valid. The code does a regular expression

preg_match('/Token token="([a-z0-9]+)"/', $tokenString

The tokens I repeatedly generated in Zendesk contain both uppercase and lowercase letters. I don't understand in the current code how it would work for anyone unless they were lucky enough to get a token containing only lowercase letters.

The expression should be modified as such /Token token="([a-zA-Z0-9]+)"/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant