Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving controller models to a separate repo #11

Open
dmarcos opened this issue Jan 13, 2017 · 8 comments
Open

Moving controller models to a separate repo #11

dmarcos opened this issue Jan 13, 2017 · 8 comments

Comments

@dmarcos
Copy link
Member

dmarcos commented Jan 13, 2017

During the WebVR spec face to face meeting we discussed about a way for developers to easily find models for the different controllers in the market, hands and other kinds of basic virtual tools. We debated whether it should be a new platform API or just an official CDN that contains all the models. A-Frame hosts the assets in the gh-pages of this repo (https://github.com/aframevr/assets/tree/gh-pages/controllers). In order for any library to benefit from those we could:

  1. Move the models to a separate repo that it's not a-frame specific.
  2. Define conventions for file names, model part names, format, license...
  3. Decide where they should be hosted (gh-pages might fall short) and the url / domain schema to handle versioning.

What do you think? @feiss @fernandojsg @toji @ngokevin @TechnoBuddhist @machenmusik

@fernandojsg
Copy link
Member

  1. I agree, maybe we could start adding them to mozilla (mozilla/webvr-assets) account and then we could decide where to move them if we come with a nice custom organization name (webvr is already used :)?
  2. I believe it would be easy to distribute the assets with a open CC license as most of the assets will be created by us or we'll encourage contributors to do so. Regarding the model part names we could follow the approach that @feiss did on the a-painter models naming them with a common prefix + lowercase + dash, like: button-a, button-b, button-trigger, button-trigger, body, ...
  3. I'd start using gh-pages and then we could decide if host it somewhere else. Not everyone will use the assets through our CDN, some probably will just download and include them into their app.

@dmarcos
Copy link
Member Author

dmarcos commented Jan 13, 2017

We may want to decouple the repo where the assets live from the domain where they're hosted. That way it will be easy to move them around if there's need without breaking URLs

@feiss
Copy link
Member

feiss commented Jan 13, 2017

Everything sounds great to me 👍

  1. Yup, not a-frame specific. Although I love the idea of Mozilla hosting them, maybe a new common repo for all parties would be more adequate? webvr is taken, some variation..
  2. Assets could be available in most common web 3d formats (obj, xml, json, gltf..), and also maybe in different levels of detail (high/med/low?).

Folder structure could reflect both versioning and level of detail:

controllers/vive/1/low/
controllers/oculus/2/high/

about filenames, they could have all the same information, in case somebody downloads the file:
controllers/oculus/2/high/webvr-controller-oculus-2-high.json

About part names, they could be as most generic as possible, so it can be easily programmable:

body
body-detail1
body-detail2
button-primary
button-secondary
button-menu
button-system
...

It's difficult to find a common denominator for all parts, but it could be interesting to have many of them with the same name.

We may want to decouple the repo where the assets live from the domain where they're hosted. That way it will be easy to move them around if there's need without breaking URLs

Agree. webvr.info could be the baseurl, for example

@TechnoBuddhist
Copy link
Contributor

TechnoBuddhist commented Jan 14, 2017 via email

@machenmusik
Copy link
Contributor

machenmusik commented Jan 14, 2017

this would cause dupes if the “thrustyvr” works on both oculus and vive!

wouldn't the manufacturer of thrustyvr be (whatever non-oculus, non-htc company makes it) and nothing to do with oculus and vive? this is not about vr platform, this is about generic controller models right?

i.e. isn't it just controllers/thrustmaster/thrustyvr/low ?

@TechnoBuddhist
Copy link
Contributor

Yup! My bad! Which makes it controllers / manufacturer / product-name / detail-level

@machenmusik
Copy link
Contributor

you may want product version in the case where a later revision changes physical packaging slightly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants