Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor tweak for school. #494

Open
ELI7VH opened this issue Jul 17, 2020 · 2 comments
Open

minor tweak for school. #494

ELI7VH opened this issue Jul 17, 2020 · 2 comments

Comments

@ELI7VH
Copy link

ELI7VH commented Jul 17, 2020

Hey, just been following the a-frame school (thanks btw, it's very nice)

image

The side margin is a bit cutoff when looking on half-screen. I could make a PR this weekend to fix, but somebody who knows the framework and is familiar with it already could probably do it in 5 seconds :)

@lainshiHenry
Copy link

Page: https://aframe.io/aframe-school/#/8

No margin issues found as of the time of this finding.
This may have already been fixed after this issue was posted.

image

@dmarcos Can you please confirm and close this?

@dmarcos
Copy link
Member

dmarcos commented Aug 14, 2023

I think still an issue. Can shrink the window horizontally to reproduce. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants