Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform controls really big #649

Open
vincentfretin opened this issue Oct 17, 2022 · 4 comments
Open

Transform controls really big #649

vincentfretin opened this issue Oct 17, 2022 · 4 comments

Comments

@vincentfretin
Copy link
Contributor

There is an issue where the transform controls doesn't resize when zooming in or out, so it appears really big when the camera is far away and you focus on a small object (with f or dblclick).
transform_controls_really_big

@vincentfretin
Copy link
Contributor Author

Normal size if I click away and reclick on the object:

transform_controls_normal_size

@dmarcos
Copy link
Member

dmarcos commented Dec 24, 2022

Any quick fix for this we can incorporate to 1.4.0?

@vincentfretin
Copy link
Contributor Author

This is most probably an update method to call after using zoom.
I quickly look at it but I'm not familiar enough with the code to do a quick fix on this.
I plan to work on updating TransformControls next year, we should be able to use the latest one from three instead of our very old one in the repository (for example setScaleSnap is missing on our old version).

Also I see that in EditorControls.js we're patching THREE.Box3.prototype.expandByObject so overriding the one from three, that's not great.

Also I would disable the dbclick to focus behavior, it's really confusing when you do it by mistake on the ground plane, it zooms out to infinity.

@vincentfretin
Copy link
Contributor Author

You can sponsor vincentfretin to expedite this fix. Find other work you can sponsor at https://github.com/c-frame/sponsorship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants