Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to generate access token #1024

Open
helgatheviking opened this issue Jan 17, 2023 · 9 comments
Open

Add link to generate access token #1024

helgatheviking opened this issue Jan 17, 2023 · 9 comments

Comments

@helgatheviking
Copy link

helgatheviking commented Jan 17, 2023

When installing a plugin/theme there's an input for adding the access token:
image

Would be helpful if the description text had a direct link to GitHub so we don't have to go look it up.

Same in the overall settings:
image

@afragen
Copy link
Owner

afragen commented Jan 17, 2023

If you are the owner of the repository or it's a public repository then this may be blank.

@afragen
Copy link
Owner

afragen commented Jan 17, 2023

I'm hoping to replace this with oAuth soon. At least in the main settings tab.

@helgatheviking
Copy link
Author

If you are the owner of the repository or it's a public repository then this may be blank.

As far as I can tell the link is in your Github settings and not specific to any particular repo. Is that correct?

Do you need to have different tokens? IE one for the rate limiting and then another for the private repo?

@afragen
Copy link
Owner

afragen commented Jan 18, 2023

If you are the owner of the repository or it's a public repository then this may be blank.

As far as I can tell the link is in your Github settings and not specific to any particular repo. Is that correct?

No, it's user specific.

Do you need to have different tokens? IE one for the rate limiting and then another for the private repo?

No, only one token

@helgatheviking
Copy link
Author

helgatheviking commented Jan 18, 2023

In that case, couldn't you remove the multiple access token fields? It's confusing if there's no actual need for it... though I admit I probably just don't understand what's going on.

image

What do the inputs do next to each plugin if you only need 1 access token?

Would something like this be easier?

image

And since there's only one link that should be easy enough to put into the description text i think.

@afragen
Copy link
Owner

afragen commented Jan 18, 2023

You need the field if you a get an access token from another developer for their private repo.

@helgatheviking
Copy link
Author

helgatheviking commented Jan 18, 2023

Ah gotcha. I think that could be more clear then in the language. Here's another proposal....

  1. only display private repos
  2. Hide the input until someone intentionally reveals it with a button click.

image

@afragen
Copy link
Owner

afragen commented Jan 18, 2023

Private repos only get designated private after the API call. Sorta a Catch-22.

The field is only present until the API response is obtained. If a API response cannot be obtained the the repo is likely private.

@afragen
Copy link
Owner

afragen commented Jan 18, 2023

I'm always open to PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants