Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MailMover.py crashes if mail was deleted #98

Closed
J-N-K opened this issue Jan 14, 2015 · 3 comments
Closed

MailMover.py crashes if mail was deleted #98

J-N-K opened this issue Jan 14, 2015 · 3 comments

Comments

@J-N-K
Copy link

J-N-K commented Jan 14, 2015

Running afew --move-mail crashes if one of the files in the notmuch database was previously deleted. This is due to the exception handling in Mailmover.py The shutil-Copy routine (l. 75) raises an exception if the file was not found and the exception-handler only takes care of "already exists" errors.

If the file was not found, it should be reported but not crash afew.

@flokli
Copy link
Member

flokli commented Apr 8, 2018

@GuillaumeSeren Can you check if #189 properly handles this? We should probably logger.warn, but then skip over that file.

@J-N-K J-N-K closed this as completed May 19, 2019
@GuillaumeSeren
Copy link
Collaborator

Hello @Floki @J-N-K,
as the refactored version of the MailMover (still welcome feedback on this patch !! :beer),
is more iterative and do a process of moving on a mail centric way before we do the whole list at once.

I think this could fix, you issue, please test the MailMover and add your feedback.

@J-N-K
Copy link
Author

J-N-K commented May 28, 2019

I‘m not using afew any longer, so i can‘t test. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants