Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notmuch-0.30 deprecate python module #278

Open
GuillaumeSeren opened this issue Aug 9, 2020 · 2 comments
Open

notmuch-0.30 deprecate python module #278

GuillaumeSeren opened this issue Aug 9, 2020 · 2 comments

Comments

@GuillaumeSeren
Copy link
Collaborator

Hey,
In notmuch-0.30 the notmuch python module is deprecated in favor of the new one notmuch2,
alot is already working on this pazz/alot#1511,
afew need to migrate too because at some point old module,
will be dropped by upstream.

https://notmuchmail.org/news/release-0.30/
@GuillaumeSeren
Copy link
Collaborator Author

GuillaumeSeren commented Aug 26, 2020 •
edited

I was checking what needed to be done on this subject

./afew/filters/MeFilter.py:7:from afew.NotmuchSettings import notmuch_settings
./afew/filters/SentMailsFilter.py:7:from afew.NotmuchSettings import notmuch_settings                                                                                                    
./afew/filters/FolderNameFilter.py:5:from afew.NotmuchSettings import notmuch_settings
./afew/tests/test_mefilter.py:7:import notmuch                                                                                                                                           
./afew/tests/test_mailmover.py:7:import notmuch                                                                                                                                          
./afew/Database.py:8:import notmuch        
./afew/MailMover.py:11:import notmuch                                                       
./afew/files.py:15:import notmuch

@GuillaumeSeren GuillaumeSeren mentioned this issue Sep 25, 2020
Open
@GuillaumeSeren
Copy link
Collaborator Author

Hey,
so after #296 / #297 there are only 3 files using the old python module

./afew/MailMover.py:11:import notmuch
./afew/Database.py:8:import notmuch
./afew/files.py:11:import notmuch

I will upgrade those to use the new notmuch2.

GuillaumeSeren added a commit to GuillaumeSeren/afew that referenced this issue Nov 11, 2020
@GuillaumeSeren
Upgrade files to notmuch2 python module afewmail#278
9ce0335 
Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
GuillaumeSeren added a commit to GuillaumeSeren/afew that referenced this issue Nov 11, 2020
@GuillaumeSeren
Upgrade Database to notmuch2 python module afewmail#278
cf74699 
Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
GuillaumeSeren added a commit to GuillaumeSeren/afew that referenced this issue Nov 11, 2020
@GuillaumeSeren
Upgrade MailMover to notmuch2 python module afewmail#278
c5a604c 
Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
GuillaumeSeren added a commit to GuillaumeSeren/afew that referenced this issue Nov 11, 2020
@GuillaumeSeren
Upgrade Database to notmuch2 python module afewmail#278
be9bc71 
Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
GuillaumeSeren added a commit to GuillaumeSeren/afew that referenced this issue Nov 11, 2020
@GuillaumeSeren
Upgrade MailMover to notmuch2 python module afewmail#278
ea67323 
Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
GuillaumeSeren added a commit to GuillaumeSeren/afew that referenced this issue Nov 11, 2020
@GuillaumeSeren
Upgrade Database to notmuch2 python module afewmail#278
ad32e57 
Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
GuillaumeSeren added a commit to GuillaumeSeren/afew that referenced this issue Nov 11, 2020
@GuillaumeSeren
Upgrade MailMover to notmuch2 python module afewmail#278
c1b9b45 
Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
GuillaumeSeren added a commit to GuillaumeSeren/afew that referenced this issue Nov 11, 2020
@GuillaumeSeren
Upgrade files to notmuch2 python module afewmail#278
0840dca 
Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
GuillaumeSeren added a commit to GuillaumeSeren/afew that referenced this issue Nov 11, 2020
@GuillaumeSeren
Upgrade Database to notmuch2 python module afewmail#278
283ee15 
Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
GuillaumeSeren added a commit to GuillaumeSeren/afew that referenced this issue Nov 11, 2020
@GuillaumeSeren
Upgrade MailMover to notmuch2 python module afewmail#278
94a9383 
Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
mjg added a commit to mjg/afew that referenced this issue Nov 26, 2021
@mjg
Adjust to open() in notmuch2
d4882f0 
283ee15 ("Upgrade Database to notmuch2 python module afewmail#278", 2020-11-11)
adjusted Databse partially to notmuch2. There, open() does not have a
create argument any more. So far, only afew's test suite needs to create
a db. So, remove the argument from afew's Database class and use
notmuch2's create() directly in the test suite.
mjg pushed a commit to mjg/afew that referenced this issue Nov 26, 2021
@GuillaumeSeren @mjg
Upgrade files to notmuch2 python module afewmail#278
3296445 
Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
mjg pushed a commit to mjg/afew that referenced this issue Nov 26, 2021
@GuillaumeSeren @mjg
Upgrade Database to notmuch2 python module afewmail#278
2df068d 
Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
mjg pushed a commit to mjg/afew that referenced this issue Nov 26, 2021
@GuillaumeSeren @mjg
Upgrade MailMover to notmuch2 python module afewmail#278
a1bec17 
Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
mjg added a commit to mjg/afew that referenced this issue Nov 26, 2021
@mjg
Adjust to open() in notmuch2
b1cb56b 
283ee15 ("Upgrade Database to notmuch2 python module afewmail#278", 2020-11-11)
adjusted Databse partially to notmuch2. There, open() does not have a
create argument any more. So far, only afew's test suite needs to create
a db. So, remove the argument from afew's Database class and use
notmuch2's create() directly in the test suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GuillaumeSeren