-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework mail move logic #188
Comments
I have started to work on the patch last night,
Which will probably a bit more work to get done, but I am on it. |
Following the afewmail#188 issue, we needed to change move() function, to be able to move, and upgrade the database a bit more lightly: * Copy the original file to the destination * Add the new file to the database * Remove the original file * Remove the original mail from db
Hey ! |
Following the afewmail#188 issue, we needed to change move() function, to be able to move, and upgrade the database a bit more lightly: * Copy the original file to the destination * Add the new file to the database * Remove the original file * Remove the original mail from db
Following the afewmail#188 issue, we needed to change move() function, to be able to move, and upgrade the database a bit more lightly: * Copy the original file to the destination * Add the new file to the database * Remove the original file * Remove the original mail from db
Caveat: This patch ignores the "rename" setting! Had to clean up quite a few mbsync problems because of that. Also, maybe it could be rebased and cut into smaller chunks that are easier to review? |
Currently, when moving files, we move the file in the filesystem and shell out to
notmuch new
, and pick up new file locations in doing that.This causes problems, as users often call
afew
vianotmuch
's hook system, and in general, it's a bit invasive operation.A better way would be to do the following on mail move:
notmuch.database.add_message()
with the new locationnotmuch.database.remove_message()
with the old locationThis would supersede #187, and fix #139.
The text was updated successfully, but these errors were encountered: