Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweet Generator Final Project Submission #4

Open
Sukhrobjon opened this issue Dec 16, 2019 · 0 comments
Open

Tweet Generator Final Project Submission #4

Sukhrobjon opened this issue Dec 16, 2019 · 0 comments

Comments

@Sukhrobjon
Copy link

  • Good work on both Dicotgram and listogram classes. But I would suggest that it is better use for loop or some kind of logic instead of a built-in method like this return self.get(word, 0) in dictogram.py file. it would improve the readability. But if you wanna keep the built-in function you need to add comments so if someone reads the code they can follow along with your logic.
  • Great work on 2nd order Markov implementation it is generating pretty accurate results(and funny).
  • Also, right now your algorithm generating a sentence with a fixed number of words defined at the beginning. it would be really cool if you add start and stop words to have better results and it would generate even better sentences.
  • Good UI, but I would choose a different font for the actual tweet on the frontend side. it was a little hard to read the text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant