Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashtable feedback #3

Open
lvreynoso opened this issue Dec 9, 2019 · 0 comments
Open

Hashtable feedback #3

lvreynoso opened this issue Dec 9, 2019 · 0 comments

Comments

@lvreynoso
Copy link

lvreynoso commented Dec 9, 2019

Hi Ariane! I've graded your hashtable submission and have some feedback for you:

  • good job on passing all unit tests
  • good job with your time complexity analysis
  • your code works, but you could make it more concise if you used the find and replace methods of your LinkedList class. It's best to try and not repeat yourself when coding, and to keep to the principle of encapsulation when writing OO code.
  • you are on the right track with implementing a method to keep track of the hash table's length in constant time, but not quite there yet. keep going!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant