Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve startup error when keys_dir is not available #4347

Merged
merged 3 commits into from May 8, 2024

Conversation

hanssv
Copy link
Member

@hanssv hanssv commented May 2, 2024

Fixes #4346

This PR is supported by the Æternity Foundation

Copy link
Member

@dincho dincho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

true ->
ok
end.

%% Note: `filelib:ensure_path/1` was introduced in OTP-25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this comment related 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just an explanation for the silly decision to use ensure_dir when ensure_path is what we want...

@hanssv hanssv merged commit d69de6f into master May 8, 2024
38 checks passed
@hanssv hanssv deleted the GH4364_improve_startup_error branch May 8, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear error message when peer-key directory is not writeable
3 participants