chore: update node to version 6.13 #1732
Conversation
| def fetch_balances(state, contract_pk, top?) do | ||
| @spec fetch_balances(State.t(), State.t(), pubkey(), boolean()) :: | ||
| {:ok, amounts()} | {:error, Error.t()} | ||
| def fetch_balances(state, async_state, contract_pk, top?) do |
There was a problem hiding this comment.
This change, and all that follows, where async_state is explicitly passed (and stored, in the case of AsyncStoreServer) are made so that the state can be reliably mocked and not relied on the global one.
|
|
||
| :rocksdb.transaction_iterator(db_ref, transaction, cf_ref, read_options) | ||
| :rocksdb.transaction_iterator(transaction, cf_ref, read_options) |
There was a problem hiding this comment.
This is a change in the library itself, related to this commit: https://gitlab.com/barrel-db/erlang-rocksdb/-/commit/d250d366e240256a84ecc91102bb2e62758b0c71?view=parallel
| @@ -152,7 +152,7 @@ defmodule AeMdwWeb.BlockchainSim do | |||
|
|
|||
| {_prev_hash, mock_blocks, mock_txs, _max_height} = | |||
| blocks | |||
| |> Enum.reduce({@genesis_prev_hash, %{}, %{}, @initial_height}, fn | |||
| |> Enum.reduce({@genesis_prev_hash, %{}, [], @initial_height}, fn | |||
There was a problem hiding this comment.
Switching them to Keyword instead of Map makes the order deterministic (some tests rely on that)
lib/ae_mdw/db/async_store.ex
Outdated
| @@ -19,17 +19,17 @@ defmodule AeMdw.Db.AsyncStore do | |||
| @typep key() :: Database.key() | |||
| @typep record() :: Database.record() | |||
| @typep table() :: Database.table() | |||
| @opaque t() :: %__MODULE__{tid: :single_async_store} | |||
| @type t() :: %__MODULE__{tid: :single_async_store} | |||
There was a problem hiding this comment.
Why do we need to expose the internal structure? I'd rather not
There was a problem hiding this comment.
Otherwise dialyzer didn't allow using pattern match on the struct itself (not only on the properties, probably because the struct is in a property) like in here: https://github.com/aeternity/ae_mdw/pull/1732/files#diff-50003680f6579cccc558e6fd7799dad10972701a70a1a307a18f977e94634e07R32 and several other places. I prefer having explicit matches, because this will make it fail sooner and more obvious, if something else gets passed, but I can change it.
There was a problem hiding this comment.
I'd rather keep structures encapsulated in their own modules than exposing them for runtime checks. We try to avoid runtime errors and prioritize encapsulation and dialyzer (static) checks. If anyone tries sending anything other than an AsyncStore is going to get caught even before executing the app
lib/ae_mdw/db/int_transfer.ex
Outdated
|
|
||
| dev_benefs = | ||
| for {protocol, _height} <- :aec_hard_forks.protocols(), | ||
| {pk, _} <- :aec_dev_reward.beneficiaries(protocol) do |
There was a problem hiding this comment.
Not sure why credo didn't catch it, but can we name unused variables anyway?
The node now requires OTP 24, so the versions of elixir and erlang were also bumped (elixir: 1.13 -> 1.16, erlang: 23 -> 26).
Most of the changes in this PR are related to the fact, that tests are now sometimes executing in different order or different speed (probably because of optimizations) and also changes in how maps are ordered (which is now not-deterministic).