fix: use tx hash instead of index in v3 api version #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sborrazas
requested changes
Apr 12, 2024
| state | ||
| |> Txs.fetch!(txi) | ||
| |> Map.put("tx_hash", Enc.encode(:tx_hash, Txs.txi_to_hash(state, txi))) | ||
| |> Map.delete("tx_index") |
There was a problem hiding this comment.
Here we're fetching the transaction twice (on fetch! and on txi_to_hash). Plus, I think hash is included already on the txs render function
There was a problem hiding this comment.
Yeah, you're correct, I've removed this. Also had to remove it from the tests since the function it was comming from was mocked to always return %{}, so i decided to return the test as it was
sborrazas
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #764