fix: update names and oracles to v3 #1725
Conversation
docs/swagger_v3/names.spec.yaml
Outdated
| @@ -1,4 +1,30 @@ | |||
| schemas: | |||
| NameTx: | |||
| properties: | |||
There was a problem hiding this comment.
This doesn't appear to be nested inside NameTx. Also, what is a NameTx? is it claim, update, revoke?
There was a problem hiding this comment.
This is so i can resue the structure inside of the latter schemas
| @@ -1,17 +1,73 @@ | |||
| schemas: | |||
| OracleTx: | |||
There was a problem hiding this comment.
Same here, what's an OracleTx? If it's an extends tx, shouldn't it be OracleExtendsTx ?
There was a problem hiding this comment.
I'm using it only for the shape of the object, so it's not written everytime it's being used
docs/swagger_v3/oracles.spec.yaml
Outdated
| type: array | ||
| items: | ||
| type: string | ||
| tx: |
There was a problem hiding this comment.
tx here should not be part of signatures
| @@ -15,6 +15,15 @@ defmodule AeMdwWeb.OracleController do | |||
|
|
|||
| @spec oracle(Conn.t(), map()) :: Conn.t() | |||
| def oracle(%Conn{assigns: %{state: state, opts: opts}} = conn, %{"id" => id}) do | |||
| with opts <- [{:v3, true} | opts], | |||
There was a problem hiding this comment.
Why use opts as part of the with statement instead of a regular variable binding?
There was a problem hiding this comment.
A habbit, on an older project we used to put the inside the with and if it's going to always match we used = instead of <-. I don't have a strong preference i can change it back
lib/ae_mdw_web/router.ex
Outdated
| @@ -57,6 +57,8 @@ defmodule AeMdwWeb.Router do | |||
| get "/micro-blocks/:hash/transactions", TxController, :micro_block_txs | |||
|
|
|||
| get "/transactions", TxController, :txs | |||
| get "/transactions/count", TxController, :count | |||
| get "/transactions/count/:id", TxController, :count_id | |||
There was a problem hiding this comment.
This didn't change, we should leave it unchanged
There was a problem hiding this comment.
I moved them because /transactions/:hash was above them and when i tried calling this it was trying to find a transaction with hash count
There was a problem hiding this comment.
This is already fixed here #1712, not yet merged, though
This addresses #1018