feat: resolve aens name to contract address when calling contract #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sborrazas
reviewed
Mar 28, 2024
lib/ae_mdw/contract.ex
Outdated
| {:ok, {:id, :contract, pubkey}} -> | ||
| pubkey | ||
|
|
||
| {:error, _} -> |
There was a problem hiding this comment.
Not sure why credo didn't catch this but unused variables should contain a reference to what it actually is (_reason in this case). But maybe it would be even better to include the reason as part of the error being raised
sborrazas
reviewed
Mar 28, 2024
lib/ae_mdw/contract.ex
Outdated
| "contract_pubkey" | ||
| |> :aec_chain.resolve_namehash(name_pk) | ||
| |> case do | ||
| {:ok, {:id, :contract, pubkey}} -> |
There was a problem hiding this comment.
Can we avoid exposing the aeser_id structure and instead use the getters to retrieve the value? Something like
{:ok, contract_id} -> :aeser_id.specialize(contract_id, :contract)
yaboiishere
force-pushed
the
ceres-call-contract-name
branch
from
3b5db43
to
043638c
Compare
yaboiishere
force-pushed
the
ceres-call-contract-name
branch
from
043638c
to
066925e
Compare
yaboiishere
force-pushed
the
ceres-call-contract-name
branch
from
04a0007
to
a48729d
Compare
sborrazas
reviewed
Apr 3, 2024
lib/ae_mdw/db/name.ex
Outdated
| def ptr_resolve(state, block_index, name_hash, pointer_key) do | ||
| with {:ok, id} <- | ||
| :aens.resolve_hash(pointer_key, name_hash, ns_tree!(state, block_index)) do | ||
| Validate.id(id) |
There was a problem hiding this comment.
Validate.id/1 might return {:error, Error.Id}, which isn't what ptr_resolve returns here. Since we know it's a valid ID we don't need to validate, and we can use :aeser_id.specialize instead, right?
sborrazas
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1708 since it's branched out from it