Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include source tx_hash on nested names endpoints #1104

Merged
merged 2 commits into from Jan 4, 2023
Merged

feat: include source tx_hash on nested names endpoints #1104

merged 2 commits into from Jan 4, 2023

Conversation

sborrazas
Copy link
Contributor

No description provided.

@sborrazas sborrazas self-assigned this Dec 29, 2022
jyeshe
jyeshe reviewed Jan 2, 2023
View reviewed changes
Copy link
Member

@jyeshe jyeshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tx hash seems helpful, the tx type is already returned under tx:
image

@sborrazas
Copy link
Contributor Author

The tx hash seems helpful, the tx type is already returned under tx: image

The tx_type does not always match the tx_type from the tx object. for instance, with name claims tx_type can either be NameClaimTx or ContractCallTx

@sborrazas sborrazas requested a review from jyeshe January 3, 2023 10:26
jyeshe
jyeshe reviewed Jan 3, 2023
View reviewed changes
Copy link
Member

@jyeshe jyeshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, might be an internal tx not the chain one. Having tx_type and tx.type that might differ it's a bit confusing to me. If not for a specific reason, indicating if it's from a contract call or not with a boolean might to be more clear.

@sborrazas
Copy link
Contributor Author

I see, might be an internal tx not the chain one. Having tx_type and tx.type that might differ it's a bit confusing to me. If not for a specific reason, indicating if it's from a contract call or not with a boolean might to be more clear.

Renamed the field to source_tx_hash and source_tx_type. Also added boolean internal_source to indicate whether it's internal or not

@sborrazas sborrazas requested a review from jyeshe January 4, 2023 10:35
@sborrazas sborrazas merged commit 15bd964 into master Jan 4, 2023
@sborrazas sborrazas deleted the tx-hash-nested-name branch January 4, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thepiwo thepiwo thepiwo approved these changes

@jyeshe jyeshe jyeshe approved these changes

Assignees

@sborrazas sborrazas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sborrazas @thepiwo @jyeshe